andrius
/
partitionmanager
1
0
Fork 0
Code Pull Requests Releases Activity

Use non-pixmap colorful icons from the icon theme in settings window's sidebar 

Summary:
This patch changes the icons in the settings' window's sidebar to be all colorful, in
conformance with T10165 specifically, and the new #consistency goal more generally.

It also cleans up the code a tiny bit by using built-in constructor functionality to set
icons from the icon theme rather than leaving the icon blank in the constructor and then
setting it later.

Test Plan:
Before: {F7449955}
After: {F7449956}

Reviewers: #vdg, #kde_partition_manager, stikonas, ndavis

Reviewed By: #vdg, #kde_partition_manager, stikonas, ndavis

Maniphest Tasks: T10165

Differential Revision: https://phabricator.kde.org/D24272
This commit is contained in:
Nate Graham 2019-09-27 14:23:59 -06:00
parent a0ce2ecbbe
commit 68d8c34535
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/config/configureoptionsdialog.cpp
View File

@ -51,19 +51,14 @@ ConfigureOptionsDialog::ConfigureOptionsDialog(QWidget* parent, const OperationS
{
setFaceType(List);
KPageWidgetItem* item = nullptr;
item = addPage(&generalPageWidget(), xi18nc("@title:tab general application settings", "General"), QString(), i18n("General Settings"));
item->setIcon(QIcon::fromTheme(QStringLiteral("partitionmanager")).pixmap(IconSize(KIconLoader::Desktop)));
addPage(&generalPageWidget(), xi18nc("@title:tab general application settings", "General"), QStringLiteral("partitionmanager"), i18n("General Settings"));
connect(&generalPageWidget().comboDefaultFileSystem(), qOverload<int>(&QComboBox::activated), this, &ConfigureOptionsDialog::onComboDefaultFileSystemActivated);
connect(generalPageWidget().radioButton, &QRadioButton::toggled, this, &ConfigureOptionsDialog::onShredSourceActivated);
item = addPage(&fileSystemColorsPageWidget(), xi18nc("@title:tab", "File System Colors"), QString(), i18n("File System Color Settings"));
item->setIcon(QIcon::fromTheme(QStringLiteral("format-fill-color")).pixmap(IconSize(KIconLoader::Desktop)));
addPage(&fileSystemColorsPageWidget(), xi18nc("@title:tab", "File System Colors"), QStringLiteral("preferences-desktop-color"), i18n("File System Color Settings"));
item = addPage(&advancedPageWidget(), xi18nc("@title:tab advanced application settings", "Advanced"), QString(), i18n("Advanced Settings"));
item->setIcon(QIcon::fromTheme(QStringLiteral("configure")).pixmap(IconSize(KIconLoader::Desktop)));
addPage(&advancedPageWidget(), xi18nc("@title:tab advanced application settings", "Advanced"), QStringLiteral("preferences-other"), i18n("Advanced Settings"));
connect(&advancedPageWidget().comboBackend(), qOverload<int>(&QComboBox::activated), this, &ConfigureOptionsDialog::onComboDefaultFileSystemActivated);