andrius
/
partitionmanager
1
0
Fork 0
Code Pull Requests Releases Activity

Don't use `d` as variable name 

On KDE and Qt apps it's common to use a d-pointer, so naming
a variable `d` has a serious implication of muscle memory.
This commit is contained in:
Tomaz Canabrava 2021-11-29 09:29:46 -03:00
parent 26ef5d3342
commit a41c31c66f
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/gui/scanprogressdialog.cpp
View File

@ -26,12 +26,13 @@ void ScanProgressDialog::closeEvent(QCloseEvent* e)
e->ignore(); e->ignore();
} }
void ScanProgressDialog::setDeviceName(const QString& d) void ScanProgressDialog::setDeviceName(const QString& device)
{ {
if (d.isEmpty()) if (device.isEmpty()) {
setLabelText(xi18nc("@label", "Scanning...")); setLabelText(xi18nc("@label", "Scanning..."));
else } else {
setLabelText(xi18nc("@label", "Scanning device: <filename>%1</filename>", d)); setLabelText(xi18nc("@label", "Scanning device: <filename>%1</filename>", device));
}
} }
void ScanProgressDialog::showEvent(QShowEvent* e) void ScanProgressDialog::showEvent(QShowEvent* e)

3
src/gui/scanprogressdialog.h
View File

@ -19,7 +19,8 @@ public:
void setProgress(int p) { void setProgress(int p) {
setValue(p); setValue(p);
} }
void setDeviceName(const QString& d);
void setDeviceName(const QString& device);
protected: protected:
void closeEvent(QCloseEvent* e) override; void closeEvent(QCloseEvent* e) override;