Don't use `d` as variable name
On KDE and Qt apps it's common to use a d-pointer, so naming a variable `d` has a serious implication of muscle memory.
This commit is contained in:
parent
26ef5d3342
commit
a41c31c66f
|
@ -26,12 +26,13 @@ void ScanProgressDialog::closeEvent(QCloseEvent* e)
|
|||
e->ignore();
|
||||
}
|
||||
|
||||
void ScanProgressDialog::setDeviceName(const QString& d)
|
||||
void ScanProgressDialog::setDeviceName(const QString& device)
|
||||
{
|
||||
if (d.isEmpty())
|
||||
if (device.isEmpty()) {
|
||||
setLabelText(xi18nc("@label", "Scanning..."));
|
||||
else
|
||||
setLabelText(xi18nc("@label", "Scanning device: <filename>%1</filename>", d));
|
||||
} else {
|
||||
setLabelText(xi18nc("@label", "Scanning device: <filename>%1</filename>", device));
|
||||
}
|
||||
}
|
||||
|
||||
void ScanProgressDialog::showEvent(QShowEvent* e)
|
||||
|
|
|
@ -19,7 +19,8 @@ public:
|
|||
void setProgress(int p) {
|
||||
setValue(p);
|
||||
}
|
||||
void setDeviceName(const QString& d);
|
||||
|
||||
void setDeviceName(const QString& device);
|
||||
|
||||
protected:
|
||||
void closeEvent(QCloseEvent* e) override;
|
||||
|
|
Loading…
Reference in New Issue