From 0cb9870ddfa1b2fec50debe6d6333cbcb3df1e7e Mon Sep 17 00:00:00 2001 From: Patrick Delaunay Date: Tue, 2 Nov 2021 11:09:12 +0100 Subject: [PATCH] fix(drivers/usb): fix Null pointer dereferences in usb_core_set_config Correct the invalid test on NULL pointer pdev->class in usb_core_set_config function. This patch fix the coverity errors: ** CID 373790: Null pointer dereferences (FORWARD_NULL) /drivers/usb/usb_device.c: 182 in usb_core_set_config() Signed-off-by: Patrick Delaunay Change-Id: I83e43261bafa2d47f800e56df0b047a6c58a1e29 --- drivers/usb/usb_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usb_device.c b/drivers/usb/usb_device.c index ce02d4fc4..27b78e7da 100644 --- a/drivers/usb/usb_device.c +++ b/drivers/usb/usb_device.c @@ -174,7 +174,7 @@ static void usb_core_set_config(struct usb_handle *pdev, struct usb_setup_req *r pdev->dev_config = cfgidx; pdev->class->de_init(pdev, cfgidx); } else if (cfgidx != pdev->dev_config) { - if (pdev->class != NULL) { + if (pdev->class == NULL) { usb_core_ctl_error(pdev); return; }