From 11a96e0ea04f4b2c53e6431f690d7912bb645552 Mon Sep 17 00:00:00 2001 From: Justin Chadwell Date: Wed, 18 Sep 2019 14:47:19 +0100 Subject: [PATCH] Remove -Wpadded warning -Wpadded warns whenever the C compiler automatically includes any padding in a structure. Because TF-A has a large number of structures, this occurs fairly frequently and is incredibly verbose, and as such is unlikely to ever be fixed. The utility of this warning is also extremely limited - knowing that a structure includes padding does not point to the existence of an error, and is probably quite unlikely to indicate actually buggy behaviour. Therefore, it's probably best to keep this warning off at all times. Change-Id: I0797cb75f06b4fea0d2fdc16fd5ad978a31d76ec Signed-off-by: Justin Chadwell --- Makefile | 1 - docs/process/security-hardening.rst | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index ef3ee4b53..b9584ca98 100644 --- a/Makefile +++ b/Makefile @@ -261,7 +261,6 @@ WARNING3 := -Wbad-function-cast WARNING3 += -Wcast-qual WARNING3 += -Wconversion WARNING3 += -Wpacked -WARNING3 += -Wpadded WARNING3 += -Wpointer-arith WARNING3 += -Wredundant-decls WARNING3 += -Wswitch-default diff --git a/docs/process/security-hardening.rst b/docs/process/security-hardening.rst index 49678719f..a18a79203 100644 --- a/docs/process/security-hardening.rst +++ b/docs/process/security-hardening.rst @@ -30,9 +30,8 @@ Several build options can be used to check for security issues. Refer to the - W=1 - Adds ``Wextra``, ``Wmissing-declarations``, ``Wmissing-format-attribute``, - ``Wmissing-prototypes``, ``Wold-style-definition`` and - ``Wunused-const-variable``. + Adds ``Wextra``, ``Wmissing-format-attribute``, ``Wmissing-prototypes``, + ``Wold-style-definition`` and ``Wunused-const-variable``. - W=2 @@ -42,7 +41,7 @@ Several build options can be used to check for security issues. Refer to the - W=3 Adds ``Wbad-function-cast``, ``Wcast-qual``, ``Wconversion``, ``Wpacked``, - ``Wpadded``, ``Wpointer-arith``, ``Wredundant-decls`` and + ``Wpointer-arith``, ``Wredundant-decls`` and ``Wswitch-default``. Refer to the GCC or Clang documentation for more information on the individual