andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

coverity: debugfs devfip remove comparisons to LONG_MAX 

CID 353228:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)

The checks on size and offset_address in get_entry always resolve to
false provided those fields are long long int and cannot be greater
than LONG_MAX.

Signed-off-by: Olivier Deprez <olivier.deprez@arm.com>
Change-Id: I0fac485a39ac4a40ae8c0d25a706ad74c795e130
This commit is contained in:
Olivier Deprez 2020-01-06 15:45:22 +01:00
parent 4ad18e5df3
commit 47939f6725
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/debugfs/devfip.c
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, Arm Limited. All rights reserved.
* Copyright (c) 2019-2020, Arm Limited. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -103,10 +103,6 @@ static int get_entry(chan_t *c, struct fip_entry *entry)
return -1;
}
if ((entry->size > LONG_MAX) || (entry->offset_address > LONG_MAX)) {
return -1;
}
if (entry->size == 0) {
return 0;
}