feat(morello): add support for nt_fw_config

This patch adds support to load nt_fw_config
with the information from plat_info sds
structure which is then passed from BL2 to BL33.

Signed-off-by: sah01 <sahil@arm.com>
Change-Id: I2242da7404c72a4f9c2e3d7f3b5c154890a78526
This commit is contained in:
sah01 2021-11-18 10:04:27 +00:00 committed by Chandni Cherukuri
parent 4a7a9dafbc
commit 6ad6465e5c
5 changed files with 224 additions and 12 deletions

View File

@ -16,5 +16,11 @@
max-size = <0x200>;
id = <TB_FW_CONFIG_ID>;
};
nt_fw-config {
load-address = <0x0 0xFEF00000>;
max-size = <0x0100000>;
id = <NT_FW_CONFIG_ID>;
};
};
};

View File

@ -0,0 +1,26 @@
/*
* Copyright (c) 2021, Arm Limited. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
/dts-v1/;
/ {
/* compatible string */
compatible = "arm,morello";
/*
* Place holder for platform-info node with default values.
* The values will be set to the correct values during
* the BL2 stage of boot.
*/
platform-info {
local-ddr-size = <0x0 0x0>;
#ifdef TARGET_PLATFORM_SOC
remote-ddr-size = <0x0 0x0>;
remote-chip-count = <0x0>;
multichip-mode = <0x0>;
scc-config = <0x0>;
#endif
};
};

View File

@ -204,7 +204,6 @@ void bl31_platform_setup(void)
{
int ret;
struct morello_plat_info plat_info;
struct morello_plat_info *copy_dest;
ret = sds_init();
if (ret != SDS_OK) {
@ -241,14 +240,4 @@ void bl31_platform_setup(void)
#ifdef TARGET_PLATFORM_SOC
dmc_ecc_setup(&plat_info);
#endif
/*
* Pass platform information to BL33. This method is followed as
* currently there is no BL1/BL2 involved in boot flow of MORELLO.
* When TBBR is implemented for MORELLO, this method should be removed
* and platform information should be passed to BL33 using NT_FW_CONFIG
* passing mechanism.
*/
copy_dest = (struct morello_plat_info *)MORELLO_PLATFORM_INFO_BASE;
*copy_dest = plat_info;
}

View File

@ -0,0 +1,185 @@
/*
* Copyright (c) 2021, Arm Limited. All rights reserved.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
#include <arch_helpers.h>
#include <common/debug.h>
#include <common/desc_image_load.h>
#include <drivers/arm/css/sds.h>
#include <libfdt.h>
#include "morello_def.h"
#include <plat/arm/common/plat_arm.h>
#include <plat/common/platform.h>
#ifdef TARGET_PLATFORM_FVP
/*
* Platform information structure stored in SDS.
* This structure holds information about platform's DDR
* size which is an information about multichip setup
* - Local DDR size in bytes, DDR memory in main board
*/
struct morello_plat_info {
uint64_t local_ddr_size;
} __packed;
#else
/*
* Platform information structure stored in SDS.
* This structure holds information about platform's DDR
* size which is an information about multichip setup
* - Local DDR size in bytes, DDR memory in main board
* - Remote DDR size in bytes, DDR memory in remote board
* - remote_chip_count
* - multichip mode
* - scc configuration
*/
struct morello_plat_info {
uint64_t local_ddr_size;
uint64_t remote_ddr_size;
uint8_t remote_chip_count;
bool multichip_mode;
uint32_t scc_config;
} __packed;
#endif
/* In client mode, a part of the DDR memory is reserved for Tag bits.
* Calculate the usable memory size after subtracting the Tag memory.
*/
static inline uint64_t get_mem_client_mode(uint64_t size)
{
return (size - (size / 128ULL));
}
/*******************************************************************************
* This function inserts Platform information via device tree nodes as,
* platform-info {
* local-ddr-size = <0x0 0x0>;
*#ifdef TARGET_PLATFORM_SOC
* remote-ddr-size = <0x0 0x0>;
* remote-chip-count = <0x0>;
* multichip-mode = <0x0>;
* scc-config = <0x0>;
*#endif
* };
******************************************************************************/
static int plat_morello_append_config_node(struct morello_plat_info *plat_info)
{
bl_mem_params_node_t *mem_params;
void *fdt;
int nodeoffset, err;
uint64_t usable_mem_size;
usable_mem_size = plat_info->local_ddr_size;
mem_params = get_bl_mem_params_node(NT_FW_CONFIG_ID);
if (mem_params == NULL) {
ERROR("NT_FW CONFIG base address is NULL\n");
return -1;
}
fdt = (void *)(mem_params->image_info.image_base);
/* Check the validity of the fdt */
if (fdt_check_header(fdt) != 0) {
ERROR("Invalid NT_FW_CONFIG DTB passed\n");
return -1;
}
nodeoffset = fdt_subnode_offset(fdt, 0, "platform-info");
if (nodeoffset < 0) {
ERROR("NT_FW_CONFIG: Failed to get platform-info node offset\n");
return -1;
}
#ifdef TARGET_PLATFORM_SOC
err = fdt_setprop_u64(fdt, nodeoffset, "remote-ddr-size",
plat_info->remote_ddr_size);
if (err < 0) {
ERROR("NT_FW_CONFIG: Failed to set remote-ddr-size\n");
return -1;
}
err = fdt_setprop_u32(fdt, nodeoffset, "remote-chip-count",
plat_info->remote_chip_count);
if (err < 0) {
ERROR("NT_FW_CONFIG: Failed to set remote-chip-count\n");
return -1;
}
err = fdt_setprop_u32(fdt, nodeoffset, "multichip-mode",
plat_info->multichip_mode);
if (err < 0) {
ERROR("NT_FW_CONFIG: Failed to set multichip-mode\n");
return -1;
}
err = fdt_setprop_u32(fdt, nodeoffset, "scc-config",
plat_info->scc_config);
if (err < 0) {
ERROR("NT_FW_CONFIG: Failed to set scc-config\n");
return -1;
}
if (plat_info->scc_config & MORELLO_SCC_CLIENT_MODE_MASK) {
usable_mem_size = get_mem_client_mode(plat_info->local_ddr_size);
}
#endif
err = fdt_setprop_u64(fdt, nodeoffset, "local-ddr-size",
usable_mem_size);
if (err < 0) {
ERROR("NT_FW_CONFIG: Failed to set local-ddr-size\n");
return -1;
}
flush_dcache_range((uintptr_t)fdt, mem_params->image_info.image_size);
return 0;
}
/*******************************************************************************
* This function returns the list of executable images.
******************************************************************************/
bl_params_t *plat_get_next_bl_params(void)
{
int ret;
struct morello_plat_info plat_info;
ret = sds_init();
if (ret != SDS_OK) {
ERROR("SDS initialization failed. ret:%d\n", ret);
panic();
}
ret = sds_struct_read(MORELLO_SDS_PLATFORM_INFO_STRUCT_ID,
MORELLO_SDS_PLATFORM_INFO_OFFSET,
&plat_info,
MORELLO_SDS_PLATFORM_INFO_SIZE,
SDS_ACCESS_MODE_NON_CACHED);
if (ret != SDS_OK) {
ERROR("Error getting platform info from SDS. ret:%d\n", ret);
panic();
}
/* Validate plat_info SDS */
#ifdef TARGET_PLATFORM_FVP
if (plat_info.local_ddr_size == 0U) {
#else
if ((plat_info.local_ddr_size == 0U)
|| (plat_info.local_ddr_size > MORELLO_MAX_DDR_CAPACITY)
|| (plat_info.remote_ddr_size > MORELLO_MAX_DDR_CAPACITY)
|| (plat_info.remote_chip_count > MORELLO_MAX_REMOTE_CHIP_COUNT)
){
#endif
ERROR("platform info SDS is corrupted\n");
panic();
}
ret = plat_morello_append_config_node(&plat_info);
if (ret != 0) {
panic();
}
return arm_get_next_bl_params();
}

View File

@ -40,8 +40,10 @@ BL1_SOURCES := ${MORELLO_CPU_SOURCES} \
BL2_SOURCES := ${MORELLO_BASE}/morello_security.c \
${MORELLO_BASE}/morello_err.c \
${MORELLO_BASE}/morello_trusted_boot.c \
${MORELLO_BASE}/morello_bl2_setup.c \
${MORELLO_BASE}/morello_image_load.c \
lib/utils/mem_region.c \
${MORELLO_BASE}/morello_bl2_setup.c
drivers/arm/css/sds/sds.c
BL31_SOURCES := ${MORELLO_CPU_SOURCES} \
${INTERCONNECT_SOURCES} \
@ -54,14 +56,18 @@ BL31_SOURCES := ${MORELLO_CPU_SOURCES} \
FDT_SOURCES += fdts/morello-${TARGET_PLATFORM}.dts \
${MORELLO_BASE}/fdts/morello_fw_config.dts \
${MORELLO_BASE}/fdts/morello_tb_fw_config.dts \
${MORELLO_BASE}/fdts/morello_nt_fw_config.dts
FW_CONFIG := ${BUILD_PLAT}/fdts/morello_fw_config.dtb
TB_FW_CONFIG := ${BUILD_PLAT}/fdts/morello_tb_fw_config.dtb
NT_FW_CONFIG := ${BUILD_PLAT}/fdts/morello_nt_fw_config.dtb
# Add the FW_CONFIG to FIP and specify the same to certtool
$(eval $(call TOOL_ADD_PAYLOAD,${FW_CONFIG},--fw-config,${FW_CONFIG}))
# Add the TB_FW_CONFIG to FIP and specify the same to certtool
$(eval $(call TOOL_ADD_PAYLOAD,${TB_FW_CONFIG},--tb-fw-config,${TB_FW_CONFIG}))
# Add the NT_FW_CONFIG to FIP and specify the same to certtool
$(eval $(call TOOL_ADD_PAYLOAD,${NT_FW_CONFIG},--nt-fw-config,${NT_FW_CONFIG}))
MORELLO_FW_NVCTR_VAL := 0
TFW_NVCTR_VAL := ${MORELLO_FW_NVCTR_VAL}