From 805f22babdc26601f32dc44bb547cc4d5a0447a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pali=20Roh=C3=A1r?= Date: Tue, 16 Feb 2021 18:05:57 +0100 Subject: [PATCH] Print newline after hex address in aarch64 el3_panic function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make the aarch64's el3_panic() function print a newline character after PC address, otherwise the output can get mangled in one line with output from other firmware. Here is an example of how the output of el3_panic() got mangled with Linux' console output: ERROR: Unhandled External Abort received on 0x80000001 at EL3! ERROR: exception reason=1 syndrome=0x92000210 PANIC at PC : 0x0000000004027400[13438.473133] rcu: INFO: rcu_sched detected stalls on CPUs/tasks: [13438.479255] rcu: 1-...0: (4 ticks this GP) idle=35e/1/0x4000000000000000 softirq=146459/146459 fqs=2625 The aarch32 version of this function already does this. Signed-off-by: Pali Rohár Change-Id: I9f0d032c6cd1e2be7a1837f9c8e8244d30633993 --- common/aarch64/debug.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/aarch64/debug.S b/common/aarch64/debug.S index ad6acd9d2..d105d0871 100644 --- a/common/aarch64/debug.S +++ b/common/aarch64/debug.S @@ -208,6 +208,9 @@ el3_panic: sub x4, x4, #4 bl asm_print_hex + /* Print new line */ + bl asm_print_newline + bl plat_crash_console_flush _panic_handler: