andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Semihosting: Fix file mode to load binaries on Windows 

Trusted firmware binaries loaded via semihosting used to be
opened using 'r' mode (i.e. read mode).  This is fine on POSIX
conforming systems (including Linux) but for Windows it also means
that the file should be opened in text mode. 'rb' mode must be
specified instead for binary mode.  On POSIX conforming systems,
'rb' mode is equivalent to 'r' mode so it does no harm.

Fixes ARM-software/tf-issues#69

Change-Id: Ifa53f2ecfd765f572dea5dd73191f9fe2b2c2011
This commit is contained in:
Sandrine Bailleux 2014-03-20 15:51:02 +00:00 committed by Dan Handley
parent 6ba0b6d674
commit 886278e55f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plat/fvp/plat_io_storage.c
View File

@ -60,22 +60,22 @@ static io_block_spec fip_block_spec = {
static io_file_spec bl2_file_spec = {
.path = BL2_IMAGE_NAME,
.mode = FOPEN_MODE_R
.mode = FOPEN_MODE_RB
};
static io_file_spec bl31_file_spec = {
.path = BL31_IMAGE_NAME,
.mode = FOPEN_MODE_R
.mode = FOPEN_MODE_RB
};
static io_file_spec bl32_file_spec = {
.path = BL32_IMAGE_NAME,
.mode = FOPEN_MODE_R
.mode = FOPEN_MODE_RB
};
static io_file_spec bl33_file_spec = {
.path = BL33_IMAGE_NAME,
.mode = FOPEN_MODE_R
.mode = FOPEN_MODE_RB
};
static int open_fip(void *spec);