andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qti: spmi_arb: Fix coverity integer conversion warnings 

Coverity warns about the risk of unintended sign-exension in some of the
calculations in spmi_arb.c. While the actual numbers used are small
enough that this cannot happen in practice, it's still a good idea to
clean them up by explicitly making the constants used unsigned.

Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: Ia169e0f7c6b01b8041e8029e8c8d30ee596ba30d
This commit is contained in:
Julius Werner 2020-08-27 16:30:44 -07:00
parent a4c979ade4
commit 9694c2104c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plat/qti/common/src/spmi_arb.c
View File

@ -10,17 +10,17 @@
#include <spmi_arb.h>
#define REG_APID_MAP(apid) (0x0C440900 + 4 * i)
#define REG_APID_MAP(apid) (0x0C440900U + 4U * i)
#define NUM_APID 0x80
#define PPID_MASK (0xfff << 8)
#define PPID_MASK (0xfffU << 8)
#define REG_ARB_CMD(apid) (0x0C600000 + 0x10000 * apid)
#define REG_ARB_CMD(apid) (0x0C600000U + 0x10000U * apid)
/* These are opcodes specific to this SPMI arbitrator, *not* SPMI commands. */
#define OPC_EXT_WRITEL 0
#define OPC_EXT_READL 1
#define REG_ARB_STATUS(apid) (0x0C600008 + 0x10000 * apid)
#define REG_ARB_STATUS(apid) (0x0C600008U + 0x10000U * apid)
#define ARB_STATUS_DONE BIT(0)
#define ARB_STATUS_FAILURE BIT(1)
#define ARB_STATUS_DENIED BIT(2)
@ -29,8 +29,8 @@
/* Fake status to report driver errors. */
#define ARB_FAKE_STATUS_TIMEOUT BIT(8)
#define REG_ARB_RDATA0(apid) (0x0C600018 + 0x10000 * apid)
#define REG_ARB_WDATA0(apid) (0x0C600010 + 0x10000 * apid)
#define REG_ARB_RDATA0(apid) (0x0C600018U + 0x10000U * apid)
#define REG_ARB_WDATA0(apid) (0x0C600010U + 0x10000U * apid)
static int addr_to_apid(uint32_t addr)
{