From a4bcfe94e73db89ce2ebbb23c8e33e51eea5026a Mon Sep 17 00:00:00 2001 From: Nicolas Le Bayon Date: Tue, 10 Mar 2020 18:18:45 +0100 Subject: [PATCH] fix(drivers/st/pmic): missing error check In pmic_operate(), "regulators" node value must be checked before entering in the fdt_for_each_subnode loop. Change-Id: I1460cd24ec56ec47ab644f396b71b92973e75fb4 Signed-off-by: Nicolas Le Bayon Signed-off-by: Yann Gautier --- drivers/st/pmic/stm32mp_pmic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/st/pmic/stm32mp_pmic.c b/drivers/st/pmic/stm32mp_pmic.c index 2e925826d..be410a1f4 100644 --- a/drivers/st/pmic/stm32mp_pmic.c +++ b/drivers/st/pmic/stm32mp_pmic.c @@ -121,6 +121,9 @@ int dt_pmic_configure_boot_on_regulators(void) } regulators_node = fdt_subnode_offset(fdt, pmic_node, "regulators"); + if (regulators_node < 0) { + return -ENOENT; + } fdt_for_each_subnode(regulator_node, fdt, regulators_node) { const fdt32_t *cuint;