From d5dc774cf05f16e9cc9a010fe2533f1260c19a36 Mon Sep 17 00:00:00 2001 From: Paul Beesley Date: Wed, 6 Mar 2019 15:27:15 +0000 Subject: [PATCH 1/4] tools: Remove unused cert_create defines Change-Id: Iea72ef9ba16325cbce07eea1a975d2a96eede274 Signed-off-by: Paul Beesley --- tools/cert_create/src/tbbr/tbb_ext.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/cert_create/src/tbbr/tbb_ext.c b/tools/cert_create/src/tbbr/tbb_ext.c index d0038a2bd..ee5377fe8 100644 --- a/tools/cert_create/src/tbbr/tbb_ext.c +++ b/tools/cert_create/src/tbbr/tbb_ext.c @@ -19,10 +19,6 @@ #include "tbbr/tbb_ext.h" #include "tbbr/tbb_key.h" -/* TODO: get these values from the command line */ -#define TRUSTED_WORLD_NVCTR_VALUE 0 -#define NORMAL_WORLD_NVCTR_VALUE 0 - static ext_t tbb_ext[] = { [TRUSTED_FW_NVCOUNTER_EXT] = { .oid = TRUSTED_FW_NVCOUNTER_OID, From efb20d8bc316384d1e22ef48edb81482a219ea4e Mon Sep 17 00:00:00 2001 From: Paul Beesley Date: Wed, 6 Mar 2019 15:28:11 +0000 Subject: [PATCH 2/4] tools: Remove TODO from fiptool It is quite unlikely that this number will ever change and, if it does need to change, we should have a good reason to do so. It seems that this comment is now redundant. Change-Id: I409c764080748e338e9bc5606bbdcc475213fb6e Signed-off-by: Paul Beesley --- tools/fiptool/tbbr_config.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/fiptool/tbbr_config.h b/tools/fiptool/tbbr_config.h index 2d8977763..1fc6cad49 100644 --- a/tools/fiptool/tbbr_config.h +++ b/tools/fiptool/tbbr_config.h @@ -11,7 +11,6 @@ #include -/* TODO: Update this number as required */ #define TOC_HEADER_SERIAL_NUMBER 0x12345678 typedef struct toc_entry { From 9a2fffb800d9930232443730ceb297976c3b7bb3 Mon Sep 17 00:00:00 2001 From: Paul Beesley Date: Wed, 6 Mar 2019 15:42:50 +0000 Subject: [PATCH 3/4] drivers: Remove TODO from io_storage This TODO was added five years ago so I assume that there is not going to be a shutdown API added after all. Change-Id: If0f4e2066454df773bd9bf41ed65d3a10248a2d3 Signed-off-by: Paul Beesley --- drivers/io/io_storage.c | 3 --- include/drivers/io/io_storage.h | 2 -- 2 files changed, 5 deletions(-) diff --git a/drivers/io/io_storage.c b/drivers/io/io_storage.c index c9ff31bcc..e444f87f7 100644 --- a/drivers/io/io_storage.c +++ b/drivers/io/io_storage.c @@ -189,9 +189,6 @@ int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params) return result; } - -/* TODO: Consider whether an explicit "shutdown" API should be included */ - /* Close a connection to a device */ int io_dev_close(uintptr_t dev_handle) { diff --git a/include/drivers/io/io_storage.h b/include/drivers/io/io_storage.h index ec6db3f2a..084c67c47 100644 --- a/include/drivers/io/io_storage.h +++ b/include/drivers/io/io_storage.h @@ -79,8 +79,6 @@ int io_dev_open(const struct io_dev_connector *dev_con, * re-initialisation */ int io_dev_init(uintptr_t dev_handle, const uintptr_t init_params); -/* TODO: Consider whether an explicit "shutdown" API should be included */ - /* Close a connection to a device */ int io_dev_close(uintptr_t dev_handle); From 7d721816a3645024345ca138870baac4ab2f14d4 Mon Sep 17 00:00:00 2001 From: Paul Beesley Date: Wed, 6 Mar 2019 15:52:16 +0000 Subject: [PATCH 4/4] drivers: Remove TODO from io_fip.c The comment suggests checking version numbers and a checksum but there doesn't seem to be any usable data for either of these. For example, fip_toc_header_t doesn't contain any version information and neither does fip_toc_entry_t. As the function name "is_valid_header" suggests, this function is not concerned with checksumming any of the table of contents entries. Change-Id: I8673ae5dd37793771760169f26b2f55c15fbf587 Signed-off-by: Paul Beesley --- drivers/io/io_fip.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/io/io_fip.c b/drivers/io/io_fip.c index d4771b514..eaaf09096 100644 --- a/drivers/io/io_fip.c +++ b/drivers/io/io_fip.c @@ -85,7 +85,6 @@ static inline int compare_uuids(const uuid_t *uuid1, const uuid_t *uuid2) } -/* TODO: We could check version numbers or do a package checksum? */ static inline int is_valid_header(fip_toc_header_t *header) { if ((header->name == TOC_HEADER_NAME) && (header->serial_number != 0)) {