From d191eb247adc53b913b44f4ad9df90c5445f55c8 Mon Sep 17 00:00:00 2001 From: "Abdul Halim, Muhammad Hadi Asyrafi" Date: Mon, 18 May 2020 10:32:15 +0800 Subject: [PATCH] intel: common: Remove urgent from mailbox async Remove urgent argument from asynchrounous mailbox command as any urgent command should always be synchronous Signed-off-by: Abdul Halim, Muhammad Hadi Asyrafi Change-Id: Iaa64335db24df3a562470d0d1c3d6a3a71493319 --- plat/intel/soc/common/include/socfpga_mailbox.h | 2 +- plat/intel/soc/common/soc/socfpga_mailbox.c | 5 +---- plat/intel/soc/common/socfpga_sip_svc.c | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/plat/intel/soc/common/include/socfpga_mailbox.h b/plat/intel/soc/common/include/socfpga_mailbox.h index f44bc0ecc..710ecf0c5 100644 --- a/plat/intel/soc/common/include/socfpga_mailbox.h +++ b/plat/intel/soc/common/include/socfpga_mailbox.h @@ -141,7 +141,7 @@ void mailbox_set_qspi_direct(void); int mailbox_send_cmd(int job_id, unsigned int cmd, uint32_t *args, int len, int urgent, uint32_t *response, int resp_len); int mailbox_send_cmd_async(int job_id, unsigned int cmd, uint32_t *args, - int len, int urgent, int indirect); + int len, int indirect); int mailbox_read_response(int job_id, uint32_t *response, int resp_len); void mailbox_reset_cold(void); void mailbox_clear_response(void); diff --git a/plat/intel/soc/common/soc/socfpga_mailbox.c b/plat/intel/soc/common/soc/socfpga_mailbox.c index cbc6bfba3..39b63c987 100644 --- a/plat/intel/soc/common/soc/socfpga_mailbox.c +++ b/plat/intel/soc/common/soc/socfpga_mailbox.c @@ -168,11 +168,8 @@ int mailbox_poll_response(int job_id, int urgent, uint32_t *response, } int mailbox_send_cmd_async(int job_id, unsigned int cmd, uint32_t *args, - int len, int urgent, int indirect) + int len, int indirect) { - if (urgent) - mmio_write_32(MBOX_OFFSET + MBOX_URG, 1); - fill_mailbox_circular_buffer(MBOX_CLIENT_ID_CMD(MBOX_ATF_CLIENT_ID) | MBOX_JOB_ID_CMD(job_id) | MBOX_CMD_LEN_CMD(len) | diff --git a/plat/intel/soc/common/socfpga_sip_svc.c b/plat/intel/soc/common/socfpga_sip_svc.c index b879cfc3b..8588e933b 100644 --- a/plat/intel/soc/common/socfpga_sip_svc.c +++ b/plat/intel/soc/common/socfpga_sip_svc.c @@ -76,7 +76,7 @@ static int intel_fpga_sdm_write_buffer(struct fpga_config_info *buffer) buffer->size_written += args[2]; mailbox_send_cmd_async(send_id++ % MBOX_MAX_JOB_ID, MBOX_RECONFIG_DATA, args, 3, - CMD_CASUAL, CMD_INDIRECT); + CMD_INDIRECT); buffer->subblocks_sent++; max_blocks--;