andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fiptool: Do not call 'make clean' in 'all' target 

Calling 'make clean' in 'all' target is causing recompilation of binary
at every 'make' call, which is wrong.

Also building a new target via 'make TARGET' can cause infinite loop as
it is not defined as explicit make dependency. Dependent targets must be
specified after colon when defining target, which also prevents infinite
loops as make is able to detect these circular dependencies.

Moreover calling 'make clean' is supposed to be done by user when
configuration is changing.

So remove calling 'make clean' in 'all' target and define dependency for
'${PROJECT}' at correct place.

Signed-off-by: Pali Rohár <pali@kernel.org>
Change-Id: I70e7fd2b04b02f6a0650c82df91d58c9a4cb24d9
This commit is contained in:
Pali Rohár 2021-03-25 16:08:09 +01:00
parent 9ad1031408
commit dbeab0da96
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/fiptool/Makefile
View File

@ -44,11 +44,7 @@ endif
.PHONY: all clean distclean
# Clean before build as old fiptool might be created with
# including different PLAT_FIPTOOL_HELPER_MK.
all:
${MAKE} clean
${MAKE} ${PROJECT}
all: ${PROJECT}
${PROJECT}: ${OBJECTS} Makefile
@echo " HOSTLD $@"