andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix(intel): use macro as return value 

SMC function should strictly return INTEL_SIP_SMC_STATUS macro. Directly
returning value of variable status might cause confusion in calling
software.

Signed-off-by: Abdul Halim, Muhammad Hadi Asyrafi <muhammad.hadi.asyrafi.abdul.halim@intel.com>
Change-Id: Iea17f4feaa5c917e8b995471f3019dba6ea8dcd3
Signed-off-by: Jit Loon Lim <jit.loon.lim@intel.com>
This commit is contained in:
Abdul Halim, Muhammad Hadi Asyrafi 2020-11-20 11:06:00 +08:00 committed by Sieu Mun Tang
parent ef51b097bf
commit e0fc2d1907
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plat/intel/soc/common/socfpga_sip_svc.c
View File

@ -211,8 +211,9 @@ static int intel_fpga_config_start(uint32_t type)
status = mailbox_send_cmd(MBOX_JOB_ID, MBOX_RECONFIG, &argument, size,
CMD_CASUAL, response, &resp_len);
if (status < 0)
return status;
if (status < 0) {
return INTEL_SIP_SMC_STATUS_ERROR;
}
max_blocks = response[0];
bytes_per_block = response[1];
@ -237,7 +238,7 @@ static int intel_fpga_config_start(uint32_t type)
socfpga_bridges_disable();
}
return 0;
return INTEL_SIP_SMC_STATUS_OK;
}
static bool is_fpga_config_buffer_full(void)