From f713e5954e0906443cd20ae97e229ddbb9ab7005 Mon Sep 17 00:00:00 2001 From: Jiafei Pan Date: Tue, 29 Mar 2022 14:43:12 +0800 Subject: [PATCH] fix(nxp-ddr): fix coverity issue Check return value of mmap_add_dynamic_region(). Signed-off-by: Jiafei Pan Change-Id: I1317e4822f3da329185d54005f08047872b5cdce --- drivers/nxp/ddr/phy-gen2/phy.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/nxp/ddr/phy-gen2/phy.c b/drivers/nxp/ddr/phy-gen2/phy.c index 7dbe3a394..c8245a846 100644 --- a/drivers/nxp/ddr/phy-gen2/phy.c +++ b/drivers/nxp/ddr/phy-gen2/phy.c @@ -2216,10 +2216,14 @@ static int load_fw(uint16_t **phy_ptr, size = PHY_GEN2_MAX_IMAGE_SIZE; image_buf = (uintptr_t)phy_gen2_fw_img_buf; - mmap_add_dynamic_region(phy_gen2_fw_img_buf, + ret = mmap_add_dynamic_region(phy_gen2_fw_img_buf, phy_gen2_fw_img_buf, PHY_GEN2_MAX_IMAGE_SIZE, MT_MEMORY | MT_RW | MT_SECURE); + if (ret != 0) { + ERROR("Failed to add dynamic memory region.\n"); + return ret; + } ret = img_loadr(imem_id, &image_buf, &size); if (ret != 0) { ERROR("Failed to load %d firmware.\n", imem_id);