andrius
/
kpmcore
1
0
Fork 0
Code Pull Requests Releases Activity

House-cleaning, removing finished TODO and FIXME tasks.

This commit is contained in:
Chantara Tith 2016-08-01 03:37:53 +07:00 committed by Andrius Štikonas
parent 510feefc55
commit 87e9bf9cb5
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/lvmdevice.cpp
View File

@ -341,7 +341,7 @@ bool LvmDevice::createLV(Report& report, LvmDevice& dev, Partition& part, const
bool LvmDevice::resizeLV(Report& report, LvmDevice& dev, Partition& part)
{
Q_UNUSED(dev);
//TODO: through tests and add warning that it could currupt the user data.
//TODO: thorough tests and add warning that it could currupt the user data.
ExternalCommand cmd(report, QStringLiteral("lvm"),
{ QStringLiteral("lvresize"),
QStringLiteral("--force"), // this command could corrupt user data
@ -355,7 +355,6 @@ bool LvmDevice::resizeLV(Report& report, LvmDevice& dev, Partition& part)
bool LvmDevice::removePV(Report& report, LvmDevice& dev, const QString& pvPath)
{
//TODO: through tests
ExternalCommand cmd(report, QStringLiteral("lvm"),
{ QStringLiteral("vgreduce"),
//QStringLiteral("--yes"), // potentially corrupt user data
@ -367,7 +366,6 @@ bool LvmDevice::removePV(Report& report, LvmDevice& dev, const QString& pvPath)
bool LvmDevice::insertPV(Report& report, LvmDevice& dev, const QString& pvPath)
{
//TODO: through tests
ExternalCommand cmd(report, QStringLiteral("lvm"),
{ QStringLiteral("vgextend"),
//QStringLiteral("--yes"), // potentially corrupt user data
@ -399,7 +397,6 @@ bool LvmDevice::movePV(Report& report, LvmDevice& dev, const QString& pvPath, co
bool LvmDevice::createVG(Report& report, const QString vgname, const QStringList pvlist, const qint32 peSize)
{
//TODO: check that all the pv in pvlist are lvm2_pv
QStringList args = QStringList();
args << QStringLiteral("vgcreate") << QStringLiteral("--physicalextentsize") << QString::number(peSize);
args << vgname;

1
src/gui/partresizerwidget.cpp
View File

@ -135,7 +135,6 @@ qint32 PartResizerWidget::handleWidth() const
long double PartResizerWidget::sectorsPerPixel() const
{
//FIXME: Make sure that this function never return 0
return totalSectors() / (width() - 2.0L * handleWidth());
}

2
src/plugins/libparted/libpartedbackend.cpp
View File

@ -276,7 +276,7 @@ Device* LibPartedBackend::scanDevice(const QString& deviceNode)
luksFs->setMounted(mounted);
} else if (fsType == FileSystem::Lvm2_PV) {
//TODO: adding PartitionRole
r |= PartitionRole::Lvm_Lv;
mountPoint = FS::lvm2_pv::getVGName(partitionNode);
mounted = false;
} else {