From c556f39064569eded28864771ccad88841608c08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrius=20=C5=A0tikonas?= Date: Sun, 29 Nov 2020 00:58:55 +0000 Subject: [PATCH] Add a limit on blocksize to prevent out-of-memory situation. --- src/util/externalcommandhelper.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/util/externalcommandhelper.cpp b/src/util/externalcommandhelper.cpp index 6c58213..e485986 100644 --- a/src/util/externalcommandhelper.cpp +++ b/src/util/externalcommandhelper.cpp @@ -163,6 +163,11 @@ QVariantMap ExternalCommandHelper::CopyBlocks(const QString& sourceDevice, const if (!blockSize) { return QVariantMap(); } + constexpr qint64 MiB = 1 << 30; + if (blockSize > 100 * MiB) { + return QVariantMap(); + } + QVariantMap reply; reply[QStringLiteral("success")] = true;