Summary:
kauth helpers have a qcoreapplication started which auto-terminates after
10 seconds of idle time. this would be an added time out on top of our
life time management that is not necessary. to prevent this additional
delay simply quit the qapplication directly.
this makes helper termination almost instantaneous even when the dbus
client disappears due to crash or SIGINT, and largely removes the
need to call stopHelper altogether.
BUG: 408245
Test Plan:
both partitionmanager and calamares instantly quit the helper no matter how the client process gets terminated
other than that everything seems to work as before
Reviewers: stikonas
Differential Revision: https://phabricator.kde.org/D21559
Summary:
kauth helpers have a qcoreapplication started which auto-terminates after
10 seconds of idle time. this would be an added time out on top of our
life time management that is not necessary. to prevent this additional
delay simply quit the qapplication directly.
this makes helper termination almost instantaneous even when the dbus
client disappears due to crash or SIGINT, and largely removes the
need to call stopHelper altogether.
BUG: 408245
Test Plan:
both partitionmanager and calamares instantly quit the helper no matter how the client process gets terminated
other than that everything seems to work as before
Reviewers: stikonas
Differential Revision: https://phabricator.kde.org/D21559
Summary:
smartmontools 7.0 reports user capacity as an object that contains bytes and blocks value, instead of being an int that just contains bytes
This should fix incorrect calculation of bad blocks threshold and incorrect display of "Overall" status
Test Plan:
run partitionmanager on a system that has smartmontools 7, open smart status
overall status should be reported correctly
Reviewers: stikonas
Reviewed By: stikonas
Differential Revision: https://phabricator.kde.org/D21311
Summary: QDbus already provides enough security to the calls made by the application to the helper. Hence no need to encrypt, sign the requests of the application and verify their integrity at the helper side.
Reviewers: stikonas, cjlcarvalho
Reviewed By: stikonas
Subscribers: #kde_partition_manager
Tags: #kde_partition_manager
Differential Revision: https://phabricator.kde.org/D21275
Install the policy files to the cmake provided locations instead of hardcoding the path to /etc/dbus-1
Differential Revision: https://phabricator.kde.org/D21162
Summary: Even though constantifying these parameters won't change anything(since they are being passed by value), it is done to assure they conform to rest of the coding style
Reviewers: stikonas, cjlcarvalho, #kde_partition_manager
Reviewed By: cjlcarvalho
Subscribers: #kde_partition_manager
Tags: #kde_partition_manager
Differential Revision: https://phabricator.kde.org/D20106
Summary: unsigned long long is a "C" data type
Reviewers: stikonas, cjlcarvalho
Reviewed By: cjlcarvalho
Subscribers: #kde_partition_manager
Tags: #kde_partition_manager
Differential Revision: https://phabricator.kde.org/D20076