In the old code QByteArray fstabContents was actually empty.
Also, writeData function was opening file in append mode,
thus nothing was actually written.
Split writeData function into two:
* one for block devices
* another for writing fstab file
BUG: 417205
Summary: QDbus already provides enough security to the calls made by the application to the helper. Hence no need to encrypt, sign the requests of the application and verify their integrity at the helper side.
Reviewers: stikonas, cjlcarvalho
Reviewed By: stikonas
Subscribers: #kde_partition_manager
Tags: #kde_partition_manager
Differential Revision: https://phabricator.kde.org/D21275
Summary: Even though constantifying these parameters won't change anything(since they are being passed by value), it is done to assure they conform to rest of the coding style
Reviewers: stikonas, cjlcarvalho, #kde_partition_manager
Reviewed By: cjlcarvalho
Subscribers: #kde_partition_manager
Tags: #kde_partition_manager
Differential Revision: https://phabricator.kde.org/D20106
Add CopyTargetByteArray. CopySourceByteArray is not implemented yet.
This is only suitable for reading small amount of data such as GPT header
or FAT boot sector location. Not meant for copying whole partition because
data has to be transfered over DBus.
Differential Revision: https://phabricator.kde.org/D16487
- Including ExternalCommandHelper::ping slot to receive pings.
- Including timer to watch last ping in the service to unregister it after reaching 42 seconds without pings.
Caveats:
* copyblocks are not converted yet, but should be similar.
* There is no signaling back to main application which tells when even loop has started, so after password is entered, you need to click F5 to rescan devices
* There are some security checks but are they sufficient
Andrius Štikonas
David Edmundson
Shubham Jangra
Caio Carvalho
Huzaifa Faruqui