#1 move mount & unmount to Filesystem

Merged
andrius merged 1 commits from :master into master 4 years ago
Ghost commented 4 years ago

I've changed mount and unmount API as well, adding report to the parameter. The reason for this is to give user error message when the operations go wrong.

  • This will also fix luks inner filesystem mounting and unmounting
  • this will also add error message for linuxswap operations
I've changed mount and unmount API as well, adding report to the parameter. The reason for this is to give user error message when the operations go wrong. - This will also fix luks inner filesystem mounting and unmounting - this will also add error message for linuxswap operations
andrius commented 4 years ago
Poster
Owner

Seems to work except for one thing:

canMount is now always set true which I think will not be the case when there is no mountpoint, no fstab entry. So GUI used to disable Mount in that case but now it is enabled and fails.

Oh, and can you fix a spelling mistake in the message of first commit.

Seems to work except for one thing: canMount is now always set true which I think will not be the case when there is no mountpoint, no fstab entry. So GUI used to disable Mount in that case but now it is enabled and fails. Oh, and can you fix a spelling mistake in the message of first commit.
Ghost commented 4 years ago
Poster

I've updated the patch with the changes... let me know what you think. :)

I've updated the patch with the changes... let me know what you think. :)
andrius commented 4 years ago
Poster
Owner

Thanks! It seems to work now. I'll merge it now. In the unlikely case that there is something else, we can always fix later.

Thanks! It seems to work now. I'll merge it now. In the unlikely case that there is something else, we can always fix later.
andrius closed this pull request 4 years ago
The pull request has been merged as 1bdafec73b.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.