andrius
/
kpmcore
1
0
Fork 0
Code Pull Requests Releases Activity

move mount & unmount to Filesystem #1

Merged
andrius merged 1 commits from :master into master 2016-05-13 22:59:05 +01:00
Conversation 3 Commits 1 Files Changed 7 +44 -37
Ghost commented 2016-05-13 18:02:53 +01:00
First-time contributor
Copy Link

I've changed mount and unmount API as well, adding report to the parameter. The reason for this is to give user error message when the operations go wrong.

  • This will also fix luks inner filesystem mounting and unmounting
  • this will also add error message for linuxswap operations
I've changed mount and unmount API as well, adding report to the parameter. The reason for this is to give user error message when the operations go wrong. - This will also fix luks inner filesystem mounting and unmounting - this will also add error message for linuxswap operations
andrius commented 2016-05-13 18:35:05 +01:00
Owner
Copy Link

Seems to work except for one thing:

canMount is now always set true which I think will not be the case when there is no mountpoint, no fstab entry. So GUI used to disable Mount in that case but now it is enabled and fails.

Oh, and can you fix a spelling mistake in the message of first commit.

Seems to work except for one thing: canMount is now always set true which I think will not be the case when there is no mountpoint, no fstab entry. So GUI used to disable Mount in that case but now it is enabled and fails. Oh, and can you fix a spelling mistake in the message of first commit.
Ghost commented 2016-05-13 20:25:19 +01:00
Author
First-time contributor
Copy Link

I've updated the patch with the changes... let me know what you think. :)

I've updated the patch with the changes... let me know what you think. :)
andrius commented 2016-05-13 22:59:03 +01:00
Owner
Copy Link

Thanks! It seems to work now. I'll merge it now. In the unlikely case that there is something else, we can always fix later.

Thanks! It seems to work now. I'll merge it now. In the unlikely case that there is something else, we can always fix later.
andrius closed this pull request 2016-05-13 22:59:05 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: andrius/kpmcore#1
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?