Bugfixes bytevectors.

* math.c (modulo): Modulo of negative value correctly.
* module/mes/bytevectors.mes (bytevector-u32-native-set!):
  (bytevector-u16-native-set!): Use ash instead of quotient.
This commit is contained in:
Jan Nieuwenhuizen 2017-01-04 20:20:15 +01:00
parent 921c2fe79e
commit 40593ac218
2 changed files with 10 additions and 7 deletions

4
math.c
View File

@ -115,7 +115,9 @@ modulo (SCM a, SCM b)
{
assert (TYPE (a) == NUMBER);
assert (TYPE (b) == NUMBER);
return MAKE_NUMBER (VALUE (a) % VALUE (b));
int x = VALUE (a);
while (x < 0) x += VALUE (b);
return MAKE_NUMBER (x % VALUE (b));
}
SCM

View File

@ -1,7 +1,7 @@
;;; -*-scheme-*-
;;; Mes --- Maxwell Equations of Software
;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
;;; Copyright © 2016,2017 Jan Nieuwenhuizen <janneke@gnu.org>
;;;
;;; This file is part of Mes.
;;;
@ -29,17 +29,18 @@
(when (not (= 0 index)) (error "bytevector-u32-native-set! index not zero: " index " value: " value))
(let ((x (list
(modulo value #x100)
(quotient (modulo value #x10000) #x100)
(quotient (modulo value #x1000000) #x10000)
(quotient value #x1000000))))
(modulo (ash value -8) #x100)
(modulo (ash value -16) #x100)
(modulo (ash value -24) #x100))))
(set-car! bv (car x))
(set-cdr! bv (cdr x))
x))
(define (bytevector-u16-native-set! bv index value)
(when (not (= 0 index)) (error "bytevector-u16-native-set! index not zero: " index " value: " value))
(let ((x (list (modulo value #x100)
(quotient (modulo value #x10000) #x100))))
(let ((x (list
(modulo value #x100)
(modulo (ash value -8) #x100))))
(set-car! bv (car x))
(set-cdr! bv (cdr x))
x))