From 7117c890f09b411f57c1b24002ba226b4aba7eb5 Mon Sep 17 00:00:00 2001
From: Anton Tolchanov <commits@knyar.net>
Date: Sun, 7 Feb 2021 16:42:52 +0000
Subject: [PATCH] Add a few tests for NeoHub._send

---
 .gitlab-ci.yml       | 10 +++---
 tests/test_neohub.py | 81 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+), 4 deletions(-)
 create mode 100644 tests/test_neohub.py

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 89529c2..56c5129 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -2,13 +2,15 @@ image: "python:3.8"
 
 before_script:
   - python --version
-  - pip3 install flake8
+  - pip3 install flake8 pytest-asyncio async_property
 
 stages:
-  - Static Analysis
+  - test
 
-flake8:
-  stage: Static Analysis
+test:
+  stage: test
   script:
   - flake8 --max-line-length=120 neohubapi/*.py
+  - flake8 --max-line-length=120 tests/*.py
   - flake8 --max-line-length=120 scripts/*.py
+  - python -m pytest
diff --git a/tests/test_neohub.py b/tests/test_neohub.py
new file mode 100644
index 0000000..8f6f597
--- /dev/null
+++ b/tests/test_neohub.py
@@ -0,0 +1,81 @@
+import asyncio
+import json
+import pytest
+from types import SimpleNamespace
+
+import neohubapi
+
+HOST = 'localhost'
+
+
+class FakeProtocol(asyncio.Protocol):
+    """A simple asyncio protocol that returns a given message."""
+    def connection_made(self, transport):
+        self.transport = transport
+
+    def data_received(self, data):
+        input = data.decode()
+        # self.handler() is set by create_protocol below.
+        output = self.handler(input).encode() + b'\0'
+        self.transport.write(output)
+        self.transport.close()
+
+
+class FakeServer:
+    def __init__(self, loop, port):
+        self.port = port
+        self.loop = loop
+
+    async def start(self, handler):
+        def create_protocol():
+            fake_protocol = FakeProtocol()
+            fake_protocol.handler = handler
+            return fake_protocol
+        self.server = await self.loop.create_server(create_protocol, HOST, self.port)
+
+    async def close(self):
+        server, self.server = self.server, None
+        server.close()
+        await server.wait_closed()
+
+
+@pytest.fixture()
+async def fakeserver(event_loop, unused_tcp_port):
+    """Create a fakeserver pytest fixture."""
+    server = FakeServer(event_loop, unused_tcp_port)
+    yield server
+    await server.close()
+
+
+@pytest.mark.asyncio
+async def test_send_valid(fakeserver):
+    def handler(input):
+        return '{"message": "ok"}'
+    await fakeserver.start(handler)
+
+    hub = neohubapi.neohub.NeoHub(host=HOST, port=fakeserver.port)
+
+    # expected_reply is not set: function returns the message.
+    assert SimpleNamespace(message='ok') == await hub._send('test')
+
+    # Response equals to expected_reply: function returns True.
+    assert await hub._send('test', {'message': 'ok'}) is True
+
+    # Response not equal to expected_reply: function returns False.
+    assert await hub._send('test', {'message': 'not ok'}) is False
+
+
+@pytest.mark.asyncio
+async def test_send_invalid_json(fakeserver):
+    def handler(input):
+        return '{"message": not valid json"}'
+    await fakeserver.start(handler)
+
+    hub = neohubapi.neohub.NeoHub(host=HOST, port=fakeserver.port)
+
+    # expected_reply is set, function returns False.
+    assert await hub._send('test', {'message': 'ok'}) is False
+
+    # expected_reply is not set, function raises exception.
+    with pytest.raises(json.decoder.JSONDecodeError):
+        await hub._send('test')