andrius
/
partitionmanager
1
0
Fork 0
Code Pull Requests Releases Activity

update TODO 

don't check for length constraints when moving a partition: the length must not
change anyway and the logic wouldn't work because the length DOES change in
between calls to update first and last sector

svn path=/trunk/extragear/sysadmin/partitionmanager/; revision=1119076
This commit is contained in:
Volker Lanz 2010-04-26 14:03:41 +00:00
parent 0284f685a8
commit 42cc630639
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
TODO
View File

@ -17,16 +17,13 @@ Bugs to fix for 1.1:
* make sure the default file system can indeed be created
* fs limits in sizedialog: create ext with >4GiB, set fs to fat16 --> it's
correctly resized to 4096MiB. but if align is on, the right handle can
still be moved to the next aligned sector
* changing free space before or after a partition in the size dialog base is
broken when align is on
* Make sure progress dialog when scanning is hidden even if there are no devices
to scan.
* when changing the file system in the new dialog so that the length is
changed, make sure last sector is aligned if align is on and last sector was
aligned before
===============================================================================
For releases after 1.1:

4
src/gui/partresizerwidget.cpp
View File

@ -189,7 +189,7 @@ bool PartResizerWidget::movePartition(qint64 newFirstSector)
newFirstSector = minimumFirstSector(align());
if (align())
newFirstSector = PartitionAlignment::alignedFirstSector(device(), partition(), newFirstSector, minimumFirstSector(align()), maximumFirstSector(align()), minimumLength(), maximumLength());
newFirstSector = PartitionAlignment::alignedFirstSector(device(), partition(), newFirstSector, minimumFirstSector(align()), maximumFirstSector(align()), -1, -1);
qint64 delta = newFirstSector - partition().firstSector();
@ -213,7 +213,7 @@ bool PartResizerWidget::movePartition(qint64 newFirstSector)
}
if (align())
newLastSector = PartitionAlignment::alignedLastSector(device(), partition(), newLastSector, minimumLastSector(align()), maximumLastSector(align()), minimumLength(), maximumLength(), originalLength, isLengthAligned);
newLastSector = PartitionAlignment::alignedLastSector(device(), partition(), newLastSector, minimumLastSector(align()), maximumLastSector(align()), -1, -1, originalLength, isLengthAligned);
if (newLastSector == partition().lastSector())
return false;