From ae088e1acea1cffcca33fc22262c5c6b0e3dc0ee Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Tue, 30 Nov 2021 09:43:25 -0300 Subject: [PATCH] Move connections to the ::setupConnecctions method What's the reason of having a ::setupConnections if there's connections for the GUI outside of it? --- src/gui/mainwindow.cpp | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/gui/mainwindow.cpp b/src/gui/mainwindow.cpp index 2ba1e0c..90c18da 100644 --- a/src/gui/mainwindow.cpp +++ b/src/gui/mainwindow.cpp @@ -99,9 +99,6 @@ MainWindow::MainWindow(QWidget* parent) : setupObjectNames(); setupUi(this); - connect(&m_ListDevices->listDevices(), &QListWidget::customContextMenuRequested, this, &MainWindow::listDevicesContextMenuRequested); - connect(&m_TreeLog->treeLog(), &QTreeWidget::customContextMenuRequested, this, &MainWindow::treeLogContextMenuRequested); - connect(&m_ListOperations->listOperations(), &QListWidget::customContextMenuRequested, this, &MainWindow::listOperationsContextMenuRequested); init(); } @@ -118,8 +115,6 @@ void MainWindow::init() { treeLog().init(); - connect(GlobalLog::instance(), &GlobalLog::newMessage, &treeLog(), &TreeLog::onNewLogMessage); - setupActions(); setupStatusBar(); setupConnections(); @@ -449,8 +444,21 @@ void MainWindow::setupActions() void MainWindow::setupConnections() { - connect(&listDevices(), &ListDevices::selectionChanged, &pmWidget(), qOverload(&PartitionManagerWidget::setSelectedDevice)); - connect(&listDevices(), &ListDevices::deviceDoubleClicked, this, &MainWindow::onPropertiesDevice); + connect(&listDevices(), &ListDevices::selectionChanged, + &pmWidget(), qOverload(&PartitionManagerWidget::setSelectedDevice)); + + connect(&listDevices(), &ListDevices::deviceDoubleClicked, + this, &MainWindow::onPropertiesDevice); + + connect(&m_ListDevices->listDevices(), &QListWidget::customContextMenuRequested, + this, &MainWindow::listDevicesContextMenuRequested); + connect(&m_TreeLog->treeLog(), &QTreeWidget::customContextMenuRequested, + this, &MainWindow::treeLogContextMenuRequested); + connect(&m_ListOperations->listOperations(), &QListWidget::customContextMenuRequested, + this, &MainWindow::listOperationsContextMenuRequested); + + connect(GlobalLog::instance(), &GlobalLog::newMessage, + &treeLog(), &TreeLog::onNewLogMessage); } void MainWindow::setupStatusBar()