Commit Graph

685 Commits

Author SHA1 Message Date
Andrius Štikonas 62e330b0f9 Remove an extra pair of brackets. 2020-09-14 00:46:02 +01:00
Andrius Štikonas 89dcf7855c Fix an infinite loop in remove mount point function. 2020-09-14 00:42:35 +01:00
Andrius Štikonas 0b77294e3d Port away from KRun to KIO::OpenUrlJob
Also bump minimum KF5 version to 5.71
2020-09-12 23:21:18 +01:00
Andrius Štikonas c3c5fd8837 Move KMessageBox outside if statement. 2020-09-10 01:23:55 +01:00
Andrius Štikonas d0bfbd2d4b Allow selecting properties using keyboard and mouse.
Properties in Dialog and Partition properties dialogs should now
be selectable.

BUG: 422192
2020-05-28 21:18:52 +01:00
Andrius Štikonas 4106ed78fd
Port away from deprecated IconSize method in the remaining dialogs. 2020-03-22 01:10:35 +00:00
Andrius Štikonas ae711eb12b Port away from deprecated IconSize method. 2020-03-15 23:16:09 +00:00
Yuri Chornoivan dcc665cc27 Fix minor EBN issues 2019-12-09 18:33:04 +02:00
Andrius Štikonas 910de2a772 Merge partition manager toolbars into one.
BUG: 412376
2019-10-05 11:21:14 +01:00
Andrius Štikonas dd0df390da Port away from deprecated QTreeWidget::setFirstItemColumnSpanned. 2019-09-27 23:09:05 +01:00
Andrius Štikonas a6861bf202 When importing partition table, pass the flags to Partition class.
Note, this is not enough for flags to work. We need to run a job to set flags.

CCBUG: 400331
2019-02-28 00:16:50 +00:00
Andrius Štikonas cf513b9873 Use explicit class method overrides. 2019-02-28 00:16:32 +00:00
Andrius Štikonas 730b2a9992 Fix race condition in reading fstype on partition table import.
Thanks to Christoph Vogtländer for reporting and fixing.

BUG: 400330
2019-02-27 23:15:17 +00:00
Andrius Štikonas 98d59e69ff
Use scoped enums for PartitionTable::Flag. 2019-02-10 01:30:02 +00:00
Yuri Chornoivan 7e47ebe0a2 Fix minor typo 2018-12-09 20:38:44 +02:00
Varun Patel beed97ee84 Updated SMART widget GUI to better display SMART info.
Repositioned information and resized window to clearly display information.

BUG: 401230
Differential Revision: https://phabricator.kde.org/D17129
2018-11-24 20:17:47 +00:00
Andrius Štikonas 58cfa4b2bb Adjust whitespace. 2018-10-28 21:27:52 +00:00
Andrius Štikonas 78e7c7d52a Fix crash on exit.
If we do not delete ApplyProgressDialog, then it later emits
finished which in turn attempts to scanDevices even though kpmcore helper
is already stopped and QCA private key is deleted.
2018-09-01 22:34:46 +01:00
Andrius Štikonas e2b31f81fb Merge branch 'kauth' 2018-07-25 09:38:54 +00:00
Caio Carvalho f21b42d10e Adding PVs that are member of VGs that are going to be deleted soon in CreateVolumeGroupDialog and ResizeVolumeGroupDialog. Avoiding segfault because of devices partition tables in CreateVolumeGroupDialog and ResizeVolumeGroupDialog. 2018-07-23 13:38:30 -03:00
Caio Carvalho 15f19e818c RAID level should not be showed when the device is inactive. (i.e. it's not loaded by mdadm). 2018-07-16 15:51:16 -03:00
Andrius Štikonas 773cbf6d3b Newly created / to be removed LVM PVs in Resize VG dialog
Port changes from Create VG dialog:
Commit: af9fbe8a4f
2018-07-16 00:20:00 +01:00
Caio Carvalho b68db554f6 Operations should check LvmDevice::s_DirtyPVs instead of check pending CreateVolumeGroupOperations to search for newly LVM PVs. 2018-07-15 19:43:44 -03:00
Andrius Štikonas 65eb5178f1 Static cast should be sufficient
We manually check device type jsut before cast
2018-07-12 09:58:50 +00:00
Caio Carvalho a606306e79 Showing SoftwareRAID device properties and allowing to create RAID device partition table. 2018-07-11 12:23:10 -03:00
Andrius Štikonas e7589702b9 Fix a compile warning. 2018-07-08 10:57:16 +01:00
René J.V. Bertin ade8676d23 avoid nullptr dereference when no devices are found
Differential revision: https://phabricator.kde.org/D13445
2018-06-09 14:27:35 +02:00
Andrius Štikonas 30815be85c Remove Kdelibs4ConfigMigrator
Config is no longer stored in root home folder, so migration cannot be done as
we have no access to root folder when running as unprivileged user.
2018-06-08 11:23:06 +01:00
Caio Carvalho 5a849d802b Checking if a new partition is targeted by a new VG through LvmDevice::s_DirtyPVs list instead of searching for a CreateVolumeGroupOperation targeting this new partition. 2018-05-28 16:24:31 -03:00
Caio Carvalho dfca46250e - Passing list of pending operations as argument to ResizeOperation::canGrow.
- Access LVM::pvList through static list attribute.
2018-05-09 04:15:28 -03:00
Caio Carvalho 556a5a22ba Don't delete, shrink or move LVM PVs that are being targeted by CreateVolumeGroupOperations. 2018-05-07 22:16:58 -03:00
Caio Carvalho 7d5d1f8f8a Listing newly created encrypted LVM PVs in Create Volume Group dialog. 2018-05-07 20:21:14 -03:00
Caio Carvalho d9b4ec0ce0 Disabling checkBoxEncrypt in Create New Partition dialog when cryptsetup tool is not found. 2018-05-07 19:22:20 -03:00
Caio Carvalho af9fbe8a4f - Allow creating LVM VG with PVs that are going to be created in OperationStack.
- Check if there is another CreateVolumeGroupOperation with the LVM PV before listing it in the LVM VG creation widget.
- Disallow creating VG with some PV that will be deleted.
2018-05-03 20:50:42 -03:00
Andrius Štikonas 2482eba7de Do not allow closing ScanProgressDialog
BUG: 393275
2018-04-19 14:29:22 +03:00
Andrius Štikonas 2846f9adba Set KAuth parent widget. 2018-04-15 01:35:55 +03:00
Andrius Štikonas 93f18ebd9f Show MainWindow before KAuth dialog. 2018-04-15 01:03:41 +03:00
Andrius Štikonas 1344021e1b Move KAuth helper setup code to ExternalCommand class. 2018-04-14 23:56:10 +03:00
Andrius Štikonas 200bb23b67 Disable ok button when it is not visible.
Otherwise it was possible to close the window before all cleanup is done
and later crash the program.
2018-04-13 16:05:13 +03:00
Andrius Štikonas c0385aca3c CoreBackendManager -> CoreBackendManager::self(). 2018-04-13 14:25:11 +03:00
Andrius Štikonas e9ac1cf977 Adjust to kpmcore enum changes. 2018-04-09 15:14:48 +01:00
Andrius Štikonas 96693a8455 Switch Device::Type enum to enum class. 2018-04-09 02:58:03 +01:00
Andrius Štikonas 2137fa58b8 Explicitely specify the scope of FileSystem::Type enum. 2018-04-07 19:54:55 +01:00
Andrius Štikonas f42da524fc enum -> enum class. 2018-04-05 22:00:06 +01:00
Huzaifa Faruqui bf65a186bd Removed config option to apply operations as non-root 2018-04-04 00:31:14 +05:30
Andrius Štikonas 3aed3ccd93 Remove obsolete CHS information. 2018-04-02 14:01:43 +01:00
Andrius Štikonas 6f8cde5520 Use for loop with iterators when removing mount points. 2018-04-01 18:47:45 +01:00
Andrius Štikonas b38db099e0 Merge branch 'master' into kauth 2018-03-31 20:29:15 +01:00
Abhijeet Sharma e54510b881 Multiple mount point support in EditMountPointDialog
Multiple mount points can also be modified and removed from fstab.

Differential Revision: https://phabricator.kde.org/D11632
2018-03-31 20:27:05 +01:00
Andrius Štikonas 2bbf89af28 Fix mutex logic for cancelling operations. 2018-03-31 20:17:38 +01:00
Caio Carvalho 079e423abd - Including tooltip for SMART attribute description. 2018-03-24 16:16:50 -03:00
abhijeet sharma a38a6cd35d Fixed the "remove existing mount point" bug
Summary:
The QString "contains method" is also searching for empty QStrings.
Due to this all entries in /etc/fstab were removed . After this patch it is
searching for only non-empty strings in removeMountPoint() function.

Reviewers: stikonas

Reviewed By: stikonas

Tags: #kde_partition_manager

Differential Revision: https://phabricator.kde.org/D11542
2018-03-22 01:29:13 +05:30
Andrius Štikonas cc73b6c9ce Move external command helper stopping code to kpmcore. 2018-03-21 20:51:10 +01:00
Andrius Štikonas 60e86c3ad6 Stop ExternalCommandHelper before quiting the application. 2018-03-19 02:34:30 +01:00
Andrius Štikonas 98209f90bc No need to explicitely set enum values. 2018-03-03 16:39:52 +00:00
Abhijeet Sharma be07085500 Add possibility to remove an existing mount point
User is able to remove an existing Mount point via
Partition -> Edit Mount Point -> Remove.

Differential Revision: https://phabricator.kde.org/D10514
2018-03-03 16:37:58 +00:00
Abhijeet Sharma 141f37ed27 Add Partition UUID and Partition Label in partition properties dialog
After this patch partition UUID and partition label will be visible
in the properties dialog of the partitions.

Also these label will only be visible if the partition table is GPT

Differential Revision: https://phabricator.kde.org/D10323
2018-02-13 21:27:05 +00:00
Andrius Štikonas eab21df647 Do not confirm overwrite twice. 2018-02-05 13:14:36 +00:00
Abhijeet Sharma 4f2381d7e6 Change default size of device and partition properties dialogs
so as to accommodate all the labels

Differential Revision: https://phabricator.kde.org/D10179
2018-01-30 15:46:05 +00:00
Andrius Štikonas d5bccabac5 Add support for displaying partition labels/uuid.
Differential Revision: https://phabricator.kde.org/D10150
2018-01-27 23:02:36 +00:00
Andrius Štikonas 6252fb480f Merge branch '3.3' 2018-01-07 16:51:50 +02:00
Andrius Štikonas 9439e9b1fd Fix a crash when resizing LVM LV. 2018-01-06 23:24:16 +02:00
Andrius Štikonas eaff75dc1b Exclude FileSystem::Luks2 from New File System dialog.
Just like with Luks1, we only want to create Luks2 containers with
some other file system inside.
2017-12-31 08:41:17 +00:00
Andrius Štikonas b4b5dcd804 Add a passphrase request dialog for LUKS2 resizing. 2017-12-31 08:41:17 +00:00
Andrius Štikonas 70f75a3f92 Treat LUKS2 file system as encrypted too. 2017-12-31 08:41:17 +00:00
Andrius Štikonas d25523e43a Properly save new fstab entries. 2017-12-03 00:17:19 +00:00
Andrius Štikonas d4c72ad075 Fix creation of FAT mountpoints.
BUG: 387463
2017-11-30 23:33:35 +00:00
Andrius Štikonas ecec8dadda Do not display cylinder/head/sector information.
CHS has never been important for Linux.
2017-11-07 00:51:59 +00:00
Andrius Štikonas f62edf052c Move LVM LV setup code to the base class.
The same checks (e.g. hide LVM LV name edit line) are also needed
in the other children of SizeDialogBase.
2017-10-28 19:02:26 +01:00
Andrius Štikonas f105f448b3 Add a validator for LVM LV names. 2017-10-09 23:56:15 +01:00
Andrius Štikonas f30a3c999f Add what's it entry to Recreate Existing File System checkbox.
BUG: 385524
2017-10-09 18:42:39 +01:00
Andrius Štikonas ca42730d39 Fix a typo in a comment. 2017-10-09 17:08:27 +01:00
Andrius Štikonas e512ed337a Use qOverload in Qt signal/slots. 2017-10-09 13:54:31 +01:00
Andrius Štikonas f34733e824 Fix regexp++. 2017-10-06 23:48:52 +01:00
Andrius Štikonas eb6478aa49 Fix a broken QRegularExpression in LVM VG name validator. 2017-10-06 23:16:30 +01:00
Andrius Štikonas cf14bdcac8 Use canonical device paths when comparing them. 2017-09-20 21:22:32 +01:00
Andrius Štikonas 9407c1ede4 Fix KUIT markup. 2017-09-20 20:39:59 +01:00
Andrius Štikonas 1c176ad5f4 Workaround for different swap naming conventions. 2017-09-18 15:21:47 +01:00
Andrius Štikonas 454845e14e Port from MountEntry to FstabEntry.
This helps to preserve comments in fstab file

BUG: 305469
2017-09-16 20:41:45 +01:00
Andrius Štikonas 24237a6120 Change a way untranslated file system name is accessed. 2017-09-15 12:47:28 +01:00
Andrius Štikonas f29656ca45 Move showColumnsContextMenu function from kpmcore to partitionmanager. 2017-09-14 20:42:43 +01:00
Andrius Štikonas 4b4198c34a Use untranslated file system name when importing partition table.
BUG: 364648
2017-09-14 14:47:39 +01:00
Andrius Štikonas aa762266ae Fix some minor clang warnings. 2017-09-11 18:46:48 +01:00
Andrius Štikonas 78eca538d6 Remove double underscore from include guards. 2017-09-11 16:28:04 +01:00
Andrius Štikonas 112b6c9f07 Move IconThemes dependency from kpmcore to partitionmanager. 2017-09-08 15:06:08 +01:00
Andrius Štikonas a9047ca6e2 Merge branch 'master' into next2 2017-09-06 00:10:29 +01:00
Andrius Štikonas feb2e374e4 Fix a crash when clicking cancel in ApplyProgressDialog.
BUG: 384348
2017-09-06 00:07:11 +01:00
Andrius Štikonas 20da0d64cf Port away from QRegExp. 2017-09-05 12:55:44 +01:00
Andrius Štikonas da621fbfbe Use QValidator to validate label input. 2017-09-05 12:52:47 +01:00
Andrius Štikonas 0f64ac2dc3 Port to validateLabel function. 2017-09-04 17:39:39 +01:00
Andrius Štikonas ff45763427 Record sector size in FileSystem class. 2017-09-03 16:01:48 +01:00
Andrius Štikonas 4c46d7ad0b Adapt to kpmcore QList->QVector changes. 2017-08-31 10:49:26 +01:00
Andrius Štikonas 482c1f63a3 std::vector->QVector. 2017-08-31 10:34:58 +01:00
Andrius Štikonas 58281d6855 Adapt to kpmcore createWithLabel changes. 2017-08-31 10:21:32 +01:00
Andrius Štikonas e3c14dbbb4 Convert pvList to std::vector.
We do not need to insert elements at arbitrary locations,
so vector should be sufficient.

Postpone changes in kpmcore till later to avoid breaking API.
2017-06-05 00:28:22 +01:00
Andrius Štikonas 6889a3b17c Replace QMaps for mount point entries with std::multimap.
This allows to retain multiple fstab entries for given block device.
At the moment there is no UI to access more than one mount point entry
but at least we will not be corrupting user's fstabs when we edit
unrelated entries.
2017-06-04 23:04:52 +01:00
Andrius Štikonas 97dc11bb89 Port qSort. 2017-05-03 19:24:41 +01:00
Andrius Štikonas d9e19a2d5d Use new function overload of KRun::runUrl()
KIO 5.31 introduced a new overload of KRun::runUrl() and set deprecation
warnings on the old one.
2017-04-16 19:35:08 +01:00
Andrius Štikonas 255e34bf9e Port from deprecated ui() to uiDelegate() 2017-04-11 20:49:46 +01:00
Andrius Štikonas a33b1f516a Add missing trailing colon. 2017-01-26 23:38:37 +00:00