Commit Graph

1592 Commits

Author SHA1 Message Date
Andrius Štikonas 2846f9adba Set KAuth parent widget. 2018-04-15 01:35:55 +03:00
Andrius Štikonas 93f18ebd9f Show MainWindow before KAuth dialog. 2018-04-15 01:03:41 +03:00
Andrius Štikonas 1344021e1b Move KAuth helper setup code to ExternalCommand class. 2018-04-14 23:56:10 +03:00
Andrius Štikonas 200bb23b67 Disable ok button when it is not visible.
Otherwise it was possible to close the window before all cleanup is done
and later crash the program.
2018-04-13 16:05:13 +03:00
Andrius Štikonas c0385aca3c CoreBackendManager -> CoreBackendManager::self(). 2018-04-13 14:25:11 +03:00
Andrius Štikonas e9ac1cf977 Adjust to kpmcore enum changes. 2018-04-09 15:14:48 +01:00
Andrius Štikonas 96693a8455 Switch Device::Type enum to enum class. 2018-04-09 02:58:03 +01:00
Andrius Štikonas 2137fa58b8 Explicitely specify the scope of FileSystem::Type enum. 2018-04-07 19:54:55 +01:00
Andrius Štikonas 3c9d85d842 Use enums instead of ints when choosing filesystem color in KConfig. 2018-04-07 19:05:05 +01:00
Andrius Štikonas f42da524fc enum -> enum class. 2018-04-05 22:00:06 +01:00
Andrius Štikonas 3eae84de13 Adapt to kpmcore API changes std::array->std::vector. 2018-04-05 21:54:55 +01:00
Huzaifa Faruqui bf65a186bd Removed config option to apply operations as non-root 2018-04-04 00:31:14 +05:30
l10n daemon script 8c8e8f8b47 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-03 05:28:21 +02:00
l10n daemon script 8b355027e5 GIT_SILENT made messages (after extraction) 2018-04-03 03:29:14 +02:00
Andrius Štikonas 3aed3ccd93 Remove obsolete CHS information. 2018-04-02 14:01:43 +01:00
Andrius Štikonas 73fef8d69c Revert "Unnecessary use of a pointer for MainWindow."
This reverts commit f33695eb2f.
2018-04-02 13:01:56 +01:00
Andrius Štikonas f33695eb2f Unnecessary use of a pointer for MainWindow. 2018-04-02 01:25:21 +01:00
Andrius Štikonas 6f8cde5520 Use for loop with iterators when removing mount points. 2018-04-01 18:47:45 +01:00
Andrius Štikonas b38db099e0 Merge branch 'master' into kauth 2018-03-31 20:29:15 +01:00
Abhijeet Sharma e54510b881 Multiple mount point support in EditMountPointDialog
Multiple mount points can also be modified and removed from fstab.

Differential Revision: https://phabricator.kde.org/D11632
2018-03-31 20:27:05 +01:00
Andrius Štikonas 2bbf89af28 Fix mutex logic for cancelling operations. 2018-03-31 20:17:38 +01:00
Andrius Štikonas c40a729ba7 Do not allow the second instance of Partition Manager.
BUG: 365882
2018-03-24 22:26:45 +00:00
Caio Carvalho 079e423abd - Including tooltip for SMART attribute description. 2018-03-24 16:16:50 -03:00
Andrius Štikonas d37c0ef9ce Revert "Disallow executing KDE Partition Manager as root."
This reverts commit cfa53f6d3c.
2018-03-22 20:13:58 +00:00
Andrius Štikonas cfa53f6d3c Disallow executing KDE Partition Manager as root.
Summary:
Running GUI applications as root is a huge security risk. Especially
the X server is not secured for that. Non-root applications can easily
interact with a root running application and thus try to exploit simple
bugs in either kate/kwrite itself or in the underlying libraries such
as Qt, XLib or xcb.

On Wayland the situation can be considered worse as the compositor is
running as the normal user and is not protected to handle root windows.
It can be rather trivial to attack the root running application from the
compositor through interfaces such as scripting. This is not in the aim
of the compositors to protect against.

This change introduces a check whether the application is started as
root before any interaction with X or Wayland happens, that is prior to
creating the QApplication. If it is detected that we run as root, we
exit and print an information about how to properly edit an application
in kwrite/kate as root. The text is deliberatly not translated to keep
the threat from running as root as low as possible.

See also Differential Revision: https://phabricator.kde.org/D4634
2018-03-22 17:39:04 +00:00
abhijeet sharma a38a6cd35d Fixed the "remove existing mount point" bug
Summary:
The QString "contains method" is also searching for empty QStrings.
Due to this all entries in /etc/fstab were removed . After this patch it is
searching for only non-empty strings in removeMountPoint() function.

Reviewers: stikonas

Reviewed By: stikonas

Tags: #kde_partition_manager

Differential Revision: https://phabricator.kde.org/D11542
2018-03-22 01:29:13 +05:30
Andrius Štikonas cc73b6c9ce Move external command helper stopping code to kpmcore. 2018-03-21 20:51:10 +01:00
Andrius Štikonas 62a3b57c2d Remove --dontsu command line option. 2018-03-19 16:24:49 +01:00
Andrius Štikonas a1a535cb03 Remove checkPermissions code. 2018-03-19 02:45:18 +01:00
Andrius Štikonas 60e86c3ad6 Stop ExternalCommandHelper before quiting the application. 2018-03-19 02:34:30 +01:00
Andrius Štikonas 98209f90bc No need to explicitely set enum values. 2018-03-03 16:39:52 +00:00
Abhijeet Sharma be07085500 Add possibility to remove an existing mount point
User is able to remove an existing Mount point via
Partition -> Edit Mount Point -> Remove.

Differential Revision: https://phabricator.kde.org/D10514
2018-03-03 16:37:58 +00:00
l10n daemon script 7dd9e17a8c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-03-03 05:26:20 +01:00
l10n daemon script f227a81ff4 GIT_SILENT made messages (after extraction) 2018-03-03 03:19:01 +01:00
Abhijeet Sharma 141f37ed27 Add Partition UUID and Partition Label in partition properties dialog
After this patch partition UUID and partition label will be visible
in the properties dialog of the partitions.

Also these label will only be visible if the partition table is GPT

Differential Revision: https://phabricator.kde.org/D10323
2018-02-13 21:27:05 +00:00
Andrius Štikonas 345994c3bf Use KF5_MIN_VERSION also for ECM, now that it's part of KF 2018-02-05 21:51:42 +00:00
Andrius Štikonas eab21df647 Do not confirm overwrite twice. 2018-02-05 13:14:36 +00:00
Andrius Štikonas fa65cd116b Use defaultBackend from kpmcore.
Do not duplicate the same thing in partitionmanager.kcfg
2018-01-31 18:50:33 +00:00
Andrius Štikonas bacb2e645b Do not require pkg-config or blkid. 2018-01-31 16:26:54 +00:00
Abhijeet Sharma 4f2381d7e6 Change default size of device and partition properties dialogs
so as to accommodate all the labels

Differential Revision: https://phabricator.kde.org/D10179
2018-01-30 15:46:05 +00:00
Andrius Štikonas d5bccabac5 Add support for displaying partition labels/uuid.
Differential Revision: https://phabricator.kde.org/D10150
2018-01-27 23:02:36 +00:00
Andrius Štikonas 145e8cf0c9 Remove obsolete TODO item.
File system support libraries would be incompatible with KAuth.
2018-01-24 18:06:56 +00:00
Andrius Štikonas 21755cb449 Remove unused KService dependency. 2018-01-16 17:14:53 +01:00
Andrius Štikonas 7c49044546 Update INSTALL instructions. bzip2->xz. 2018-01-16 15:30:31 +01:00
Andrius Štikonas 74d609a782 Always show Advanced config page. 2018-01-16 15:14:47 +01:00
l10n daemon script e7354c02d1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-01-13 04:48:00 +01:00
Andrius Štikonas 6252fb480f Merge branch '3.3' 2018-01-07 16:51:50 +02:00
Andrius Štikonas f469ef204a Bump version. 2018-01-07 13:36:21 +02:00
l10n daemon script 523e07cbf5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-01-07 04:56:25 +01:00
Andrius Štikonas 9439e9b1fd Fix a crash when resizing LVM LV. 2018-01-06 23:24:16 +02:00