andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Build: change the first parameter of TOOL_ADD_IMG to lowercase 

In the next commit, I need the image name in lowercase because
output files are generally named in lowercase.

Unfortunately, TOOL_ADD_IMG takes the first argument in uppercase
since we generally use uppercase Make variables.

make_helpers/build_macros.mk provides 'uppercase' macro to convert
a string into uppercase, but 'lowercase' does not exist.  We can
implement it if we like, but it would be more straightforward to
change the argument of TOOL_ADD_IMG.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
This commit is contained in:
Masahiro Yamada 2018-01-26 11:42:01 +09:00
parent 36af3455e2
commit 33950dd8fe
7 changed files with 25 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Makefile
View File

@ -598,17 +598,17 @@ ifeq (${BL2_AT_EL3}, 0)
FIP_BL2_ARGS := tb-fw FIP_BL2_ARGS := tb-fw
endif endif
$(if ${BL2}, $(eval $(call TOOL_ADD_IMG,BL2,--${FIP_BL2_ARGS})),\ $(if ${BL2}, $(eval $(call TOOL_ADD_IMG,bl2,--${FIP_BL2_ARGS})),\
$(eval $(call MAKE_BL,2,${FIP_BL2_ARGS}))) $(eval $(call MAKE_BL,2,${FIP_BL2_ARGS})))
endif endif
ifeq (${NEED_SCP_BL2},yes) ifeq (${NEED_SCP_BL2},yes)
$(eval $(call TOOL_ADD_IMG,SCP_BL2,--scp-fw)) $(eval $(call TOOL_ADD_IMG,scp_bl2,--scp-fw))
endif endif
ifeq (${NEED_BL31},yes) ifeq (${NEED_BL31},yes)
BL31_SOURCES += ${SPD_SOURCES} BL31_SOURCES += ${SPD_SOURCES}
$(if ${BL31}, $(eval $(call TOOL_ADD_IMG,BL31,--soc-fw)),\ $(if ${BL31}, $(eval $(call TOOL_ADD_IMG,bl31,--soc-fw)),\
$(eval $(call MAKE_BL,31,soc-fw))) $(eval $(call MAKE_BL,31,soc-fw)))
endif endif
@ -620,16 +620,16 @@ ifeq (${NEED_BL32},yes)
BUILD_BL32 := $(if $(BL32),,$(if $(BL32_SOURCES),1)) BUILD_BL32 := $(if $(BL32),,$(if $(BL32_SOURCES),1))
$(if ${BUILD_BL32}, $(eval $(call MAKE_BL,32,tos-fw)),\ $(if ${BUILD_BL32}, $(eval $(call MAKE_BL,32,tos-fw)),\
$(eval $(call TOOL_ADD_IMG,BL32,--tos-fw))) $(eval $(call TOOL_ADD_IMG,bl32,--tos-fw)))
endif endif
# Add the BL33 image if required by the platform # Add the BL33 image if required by the platform
ifeq (${NEED_BL33},yes) ifeq (${NEED_BL33},yes)
$(eval $(call TOOL_ADD_IMG,BL33,--nt-fw)) $(eval $(call TOOL_ADD_IMG,bl33,--nt-fw))
endif endif
ifeq (${NEED_BL2U},yes) ifeq (${NEED_BL2U},yes)
$(if ${BL2U}, $(eval $(call TOOL_ADD_IMG,BL2U,--ap-fwu-cfg,FWU_)),\ $(if ${BL2U}, $(eval $(call TOOL_ADD_IMG,bl2u,--ap-fwu-cfg,FWU_)),\
$(eval $(call MAKE_BL,2u,ap-fwu-cfg,FWU_))) $(eval $(call MAKE_BL,2u,ap-fwu-cfg,FWU_)))
endif endif

14
make_helpers/build_macros.mk
View File

@ -123,20 +123,24 @@ endef
# TOOL_ADD_IMG allows the platform to specify an external image to be packed # TOOL_ADD_IMG allows the platform to specify an external image to be packed
# in the FIP and/or for which certificate is generated. It also adds a # in the FIP and/or for which certificate is generated. It also adds a
# dependency on the image file, aborting the build if the file does not exist. # dependency on the image file, aborting the build if the file does not exist.
# $(1) = build option to specify the image filename (SCP_BL2, BL33, etc) # $(1) = image_type (scp_bl2, bl33, etc.)
# $(2) = command line option for fiptool (--scp-fw, --nt-fw, etc) # $(2) = command line option for fiptool (--scp-fw, --nt-fw, etc)
# $(3) = FIP prefix (optional) (if FWU_, target is fwu_fip instead of fip) # $(3) = FIP prefix (optional) (if FWU_, target is fwu_fip instead of fip)
# Example: # Example:
# $(eval $(call TOOL_ADD_IMG,BL33,--nt-fw)) # $(eval $(call TOOL_ADD_IMG,bl33,--nt-fw))
define TOOL_ADD_IMG define TOOL_ADD_IMG
# Build option to specify the image filename (SCP_BL2, BL33, etc)
# This is the uppercase form of the first parameter
$(eval _V := $(call uppercase,$(1)))
$(3)CRT_DEPS += check_$(1) $(3)CRT_DEPS += check_$(1)
$(3)FIP_DEPS += check_$(1) $(3)FIP_DEPS += check_$(1)
$(call TOOL_ADD_PAYLOAD,$(value $(1)),$(2),,$(3)) $(call TOOL_ADD_PAYLOAD,$(value $(_V)),$(2),,$(3))
.PHONY: check_$(1) .PHONY: check_$(1)
check_$(1): check_$(1):
$$(if $(value $(1)),,$$(error "Platform '${PLAT}' requires $(1). Please set $(1) to point to the right file")) $$(if $(value $(_V)),,$$(error "Platform '${PLAT}' requires $(_V). Please set $(_V) to point to the right file"))
$$(if $(wildcard $(value $(1))),,$$(error '$(1)=$(value $(1))' was specified, but '$(value $(1))' does not exist)) $$(if $(wildcard $(value $(_V))),,$$(error '$(_V)=$(value $(_V))' was specified, but '$(value $(_V))' does not exist))
endef endef
################################################################################ ################################################################################

6
plat/arm/common/arm_common.mk
View File

@ -87,10 +87,10 @@ $(eval $(call add_define,MBEDTLS_SHA256_SMALLER))
# Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images # Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images
# in the FIP if the platform requires. # in the FIP if the platform requires.
ifneq ($(BL32_EXTRA1),) ifneq ($(BL32_EXTRA1),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA1,--tos-fw-extra1)) $(eval $(call TOOL_ADD_IMG,bl32_extra1,--tos-fw-extra1))
endif endif
ifneq ($(BL32_EXTRA2),) ifneq ($(BL32_EXTRA2),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA2,--tos-fw-extra2)) $(eval $(call TOOL_ADD_IMG,bl32_extra2,--tos-fw-extra2))
endif endif
# Enable PSCI_STAT_COUNT/RESIDENCY APIs on ARM platforms # Enable PSCI_STAT_COUNT/RESIDENCY APIs on ARM platforms
@ -211,7 +211,7 @@ ifneq (${TRUSTED_BOARD_BOOT},0)
BL2_SOURCES += ${AUTH_SOURCES} \ BL2_SOURCES += ${AUTH_SOURCES} \
plat/common/tbbr/plat_tbbr.c plat/common/tbbr/plat_tbbr.c
$(eval $(call TOOL_ADD_IMG,NS_BL2U,--fwu,FWU_)) $(eval $(call TOOL_ADD_IMG,ns_bl2u,--fwu,FWU_))
# We expect to locate the *.mk files under the directories specified below # We expect to locate the *.mk files under the directories specified below
ifeq (${ARM_CRYPTOCELL_INTEG},0) ifeq (${ARM_CRYPTOCELL_INTEG},0)

2
plat/arm/css/common/css_common.mk
View File

@ -49,7 +49,7 @@ $(eval $(call add_define,CSS_LOAD_SCP_IMAGES))
ifeq (${CSS_LOAD_SCP_IMAGES},1) ifeq (${CSS_LOAD_SCP_IMAGES},1)
NEED_SCP_BL2 := yes NEED_SCP_BL2 := yes
ifneq (${TRUSTED_BOARD_BOOT},0) ifneq (${TRUSTED_BOARD_BOOT},0)
$(eval $(call TOOL_ADD_IMG,SCP_BL2U,--scp-fwu-cfg,FWU_)) $(eval $(call TOOL_ADD_IMG,scp_bl2u,--scp-fwu-cfg,FWU_))
endif endif
ifeq (${CSS_USE_SCMI_SDS_DRIVER},1) ifeq (${CSS_USE_SCMI_SDS_DRIVER},1)

4
plat/hisilicon/hikey/platform.mk
View File

@ -36,10 +36,10 @@ $(eval $(call add_define,PLAT_PARTITION_MAX_ENTRIES))
# Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images # Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images
# in the FIP if the platform requires. # in the FIP if the platform requires.
ifneq ($(BL32_EXTRA1),) ifneq ($(BL32_EXTRA1),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA1,--tos-fw-extra1)) $(eval $(call TOOL_ADD_IMG,bl32_extra1,--tos-fw-extra1))
endif endif
ifneq ($(BL32_EXTRA2),) ifneq ($(BL32_EXTRA2),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA2,--tos-fw-extra2)) $(eval $(call TOOL_ADD_IMG,bl32_extra2,--tos-fw-extra2))
endif endif
ENABLE_PLAT_COMPAT := 0 ENABLE_PLAT_COMPAT := 0

4
plat/hisilicon/hikey960/platform.mk
View File

@ -29,10 +29,10 @@ $(eval $(call add_define,CRASH_CONSOLE_BASE))
# Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images # Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images
# in the FIP if the platform requires. # in the FIP if the platform requires.
ifneq ($(BL32_EXTRA1),) ifneq ($(BL32_EXTRA1),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA1,--tos-fw-extra1)) $(eval $(call TOOL_ADD_IMG,bl32_extra1,--tos-fw-extra1))
endif endif
ifneq ($(BL32_EXTRA2),) ifneq ($(BL32_EXTRA2),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA2,--tos-fw-extra2)) $(eval $(call TOOL_ADD_IMG,bl32_extra2,--tos-fw-extra2))
endif endif
ENABLE_PLAT_COMPAT := 0 ENABLE_PLAT_COMPAT := 0

4
plat/qemu/platform.mk
View File

@ -133,10 +133,10 @@ BL31_SOURCES += lib/cpus/aarch64/aem_generic.S \
# Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images # Add the build options to pack Trusted OS Extra1 and Trusted OS Extra2 images
# in the FIP if the platform requires. # in the FIP if the platform requires.
ifneq ($(BL32_EXTRA1),) ifneq ($(BL32_EXTRA1),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA1,--tos-fw-extra1)) $(eval $(call TOOL_ADD_IMG,bl32_extra1,--tos-fw-extra1))
endif endif
ifneq ($(BL32_EXTRA2),) ifneq ($(BL32_EXTRA2),)
$(eval $(call TOOL_ADD_IMG,BL32_EXTRA2,--tos-fw-extra2)) $(eval $(call TOOL_ADD_IMG,bl32_extra2,--tos-fw-extra2))
endif endif
# Disable the PSCI platform compatibility layer # Disable the PSCI platform compatibility layer