andrius
/
arm-trusted-firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Enable -Wlogical-op always 

-Wlogical-op prevents common errors with using numerical constants where
a boolean one is expected as well as when the operands of a logical
operator are the same. While these are perfectly valid behavior, they
can be a sign that something is slightly off.

This patch adds this warning to gcc and it's closest equivalent to
clang, while also fixing any warnings that enabling them causes.

Change-Id: Iabadfc1e6ee0c44eef6685a23b0aed8abef8ce89
Signed-off-by: Justin Chadwell <justin.chadwell@arm.com>
This commit is contained in:
Justin Chadwell 2019-09-18 14:13:42 +01:00 committed by Madhukar Pappireddy
parent b7f6525db6
commit d7b4cd4111
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Makefile
View File

@ -246,7 +246,6 @@ WARNING1 += -Wunused-const-variable
WARNING2 := -Waggregate-return WARNING2 := -Waggregate-return
WARNING2 += -Wcast-align WARNING2 += -Wcast-align
WARNING2 += -Wnested-externs WARNING2 += -Wnested-externs
WARNING2 += -Wlogical-op
WARNING3 := -Wbad-function-cast WARNING3 := -Wbad-function-cast
WARNING3 += -Wcast-qual WARNING3 += -Wcast-qual
@ -268,13 +267,13 @@ endif
# Compiler specific warnings # Compiler specific warnings
ifeq ($(findstring clang,$(notdir $(CC))),) ifeq ($(findstring clang,$(notdir $(CC))),)
# not using clang # not using clang
WARNINGS += -Wunused-but-set-variable \ WARNINGS += -Wunused-but-set-variable -Wmaybe-uninitialized \
-Wmaybe-uninitialized \ -Wpacked-bitfield-compat -Wshift-overflow=2 \
-Wpacked-bitfield-compat \ -Wlogical-op
-Wshift-overflow=2
else else
# using clang # using clang
WARNINGS += -Wshift-overflow -Wshift-sign-overflow WARNINGS += -Wshift-overflow -Wshift-sign-overflow \
-Wlogical-op-parentheses
endif endif
ifneq (${E},0) ifneq (${E},0)

4
drivers/mentor/i2c/mi2cv.c
View File

@ -81,14 +81,14 @@ static void mentor_i2c_interrupt_clear(void)
udelay(1); udelay(1);
} }
static int mentor_i2c_interrupt_get(void) static bool mentor_i2c_interrupt_get(void)
{ {
uint32_t reg; uint32_t reg;
/* get the interrupt flag bit */ /* get the interrupt flag bit */
reg = mmio_read_32((uintptr_t)&base->control); reg = mmio_read_32((uintptr_t)&base->control);
reg &= I2C_CONTROL_IFLG; reg &= I2C_CONTROL_IFLG;
return reg && I2C_CONTROL_IFLG; return (reg != 0U);
} }
static int mentor_i2c_wait_interrupt(void) static int mentor_i2c_wait_interrupt(void)

2
plat/xilinx/zynqmp/pm_service/pm_api_ioctl.c
View File

@ -58,7 +58,7 @@ static enum pm_ret_status pm_ioctl_set_rpu_oper_mode(unsigned int mode)
{ {
unsigned int val; unsigned int val;
if (mmio_read_32(CRL_APB_RST_LPD_TOP) && CRL_APB_RPU_AMBA_RESET) if (mmio_read_32(CRL_APB_RST_LPD_TOP) & CRL_APB_RPU_AMBA_RESET)
return PM_RET_ERROR_ACCESS; return PM_RET_ERROR_ACCESS;
val = mmio_read_32(ZYNQMP_RPU_GLBL_CNTL); val = mmio_read_32(ZYNQMP_RPU_GLBL_CNTL);