andrius
/
kpmcore
1
0
Fork 0
Code Pull Requests Releases Activity

Add a maximum file size limit when writing to /etc/fstab file.

This commit is contained in:
Andrius Štikonas 2022-03-27 14:19:56 +01:00
parent c9d7e0cd6e
commit 5afe143a19
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/util/externalcommandhelper.cpp
View File

@ -127,15 +127,19 @@ bool ExternalCommandHelper::writeData(QFile& device, const QByteArray& buffer, c
return true; return true;
} }
/** Creates a new file with given contents. /** Creates a new fstab file with given contents.
@param fileContents the data that we write @param Contents the data that we write
@return true on success @return true on success
*/ */
bool ExternalCommandHelper::WriteFstab(const QByteArray& fileContents) bool ExternalCommandHelper::WriteFstab(const QByteArray& fstabContents)
{ {
if (!isCallerAuthorized()) { if (!isCallerAuthorized()) {
return false; return false;
} }
if (fstabContents.size() > MiB) {
qCritical() << QStringLiteral("/etc/fstab size limit exceeded.");
return false;
}
QString fstabPath = QStringLiteral("/etc/fstab"); QString fstabPath = QStringLiteral("/etc/fstab");
QFile fstabFile(fstabPath); QFile fstabFile(fstabPath);
@ -146,7 +150,7 @@ bool ExternalCommandHelper::WriteFstab(const QByteArray& fileContents)
return false; return false;
} }
if (fstabFile.write(fileContents) != fileContents.size()) { if (fstabFile.write(fstabContents) != fstabContents.size()) {
qCritical() << xi18n("Could not write to file <filename>%1</filename>.", fstabPath); qCritical() << xi18n("Could not write to file <filename>%1</filename>.", fstabPath);
return false; return false;
} }

2
src/util/externalcommandhelper.h
View File

@ -43,7 +43,7 @@ public Q_SLOTS:
const QString& targetDevice, const qint64 targetOffset, const qint64 blockSize); const QString& targetDevice, const qint64 targetOffset, const qint64 blockSize);
Q_SCRIPTABLE QByteArray ReadData(const QString& device, const qint64 offset, const qint64 length); Q_SCRIPTABLE QByteArray ReadData(const QString& device, const qint64 offset, const qint64 length);
Q_SCRIPTABLE bool WriteData(const QByteArray& buffer, const QString& targetDevice, const qint64 targetOffset); Q_SCRIPTABLE bool WriteData(const QByteArray& buffer, const QString& targetDevice, const qint64 targetOffset);
Q_SCRIPTABLE bool WriteFstab(const QByteArray& fileContents); Q_SCRIPTABLE bool WriteFstab(const QByteArray& fstabContents);
private: private:
bool isCallerAuthorized(); bool isCallerAuthorized();