andrius
/
kpmcore
1
0
Fork 0
Code Pull Requests Releases Activity

set VG as mount point if the PV belongs to any #2

Closed
Ghost wants to merge 1 commits from (deleted):lvm-support into master
pull from: (deleted):lvm-support
merge into: andrius:master
Conversation 1 Commits 1 Files Changed 3 +22
Ghost commented 2016-05-23 13:15:41 +01:00
First-time contributor
Copy Link
No description provided.
andrius commented 2016-05-23 19:39:26 +01:00
Owner
Copy Link

Great work!

One small issue is that it doesn't work if LVM PV is encrypted inside LUKS container. Maybe you can make conditionals in libpartedbackend to go to LVM case after luks case too

By the way, I've now created andrius/lvm-support master here on gogs too.
Also, maybe let's call lvm pvdisplay instead of pvdisplay, so that we don't have to rely on symlinks.

Great work! One small issue is that it doesn't work if LVM PV is encrypted inside LUKS container. Maybe you can make conditionals in libpartedbackend to go to LVM case after luks case too By the way, I've now created andrius/lvm-support master here on gogs too. Also, maybe let's call lvm pvdisplay instead of pvdisplay, so that we don't have to rely on symlinks.
Ghost closed this pull request 2016-05-23 21:07:22 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: andrius/kpmcore#2
No description provided.
Delete Branch "(deleted):lvm-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?