andrius
/
kpmcore
1
0
Fork 0
Code Pull Requests 0 Releases 27 Activity
Labels Milestones
New Pull Request

#4 PV resizing and PE infos

Closed
Ghost wants to merge 2 commits from lvm-support into lvm-support
Conversation 1 Commits 2 Files Changed 2
Ghost commented 4 years ago
There is no content yet.
andrius commented 4 years ago
Poster
Owner

Hmm, one quick idea is maybe just cache

bool lvmFound = findExternal(QStringLiteral("lvm")) ? cmdSupportFileSystem : cmdSupportNone;
and then just do e.g. m_Shrink = lvmFound;

Then we will not need to uselessly look for the same executable a few times. I know, this is also the behaviour of some other filesystems in kpmcore but I should also fix them too.

I'll look at the rest of this patch tomorrow.

Hmm, one quick idea is maybe just cache *bool lvmFound = findExternal(QStringLiteral("lvm")) ? cmdSupportFileSystem : cmdSupportNone;* and then just do e.g. *m_Shrink = lvmFound;* Then we will not need to uselessly look for the same executable a few times. I know, this is also the behaviour of some other filesystems in kpmcore but I should also fix them too. I'll look at the rest of this patch tomorrow.
andrius closed this pull request 4 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'lvm-support'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes