#4 PV resizing and PE infos

Closed
Ghost wants to merge 2 commits from lvm-support into lvm-support
Ghost commented 4 years ago
There is no content yet.
andrius commented 4 years ago
Poster
Owner

Hmm, one quick idea is maybe just cache

bool lvmFound = findExternal(QStringLiteral("lvm")) ? cmdSupportFileSystem : cmdSupportNone;
and then just do e.g. m_Shrink = lvmFound;

Then we will not need to uselessly look for the same executable a few times. I know, this is also the behaviour of some other filesystems in kpmcore but I should also fix them too.

I'll look at the rest of this patch tomorrow.

Hmm, one quick idea is maybe just cache *bool lvmFound = findExternal(QStringLiteral("lvm")) ? cmdSupportFileSystem : cmdSupportNone;* and then just do e.g. *m_Shrink = lvmFound;* Then we will not need to uselessly look for the same executable a few times. I know, this is also the behaviour of some other filesystems in kpmcore but I should also fix them too. I'll look at the rest of this patch tomorrow.
andrius closed this pull request 4 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.