andrius
/
kpmcore
1
0
Fork 0
Code Pull Requests Releases Activity

PV resizing and PE infos #4

Closed
Ghost wants to merge 2 commits from lvm-support into lvm-support
pull from: lvm-support
merge into: andrius:lvm-support
Conversation 1 Commits 2 Files Changed 2 +83 -4
Ghost commented 2016-05-25 21:10:44 +01:00
First-time contributor
Copy Link
No description provided.
andrius commented 2016-05-26 00:41:15 +01:00
Owner
Copy Link

Hmm, one quick idea is maybe just cache

bool lvmFound = findExternal(QStringLiteral("lvm")) ? cmdSupportFileSystem : cmdSupportNone;
and then just do e.g. m_Shrink = lvmFound;

Then we will not need to uselessly look for the same executable a few times. I know, this is also the behaviour of some other filesystems in kpmcore but I should also fix them too.

I'll look at the rest of this patch tomorrow.

Hmm, one quick idea is maybe just cache *bool lvmFound = findExternal(QStringLiteral("lvm")) ? cmdSupportFileSystem : cmdSupportNone;* and then just do e.g. *m_Shrink = lvmFound;* Then we will not need to uselessly look for the same executable a few times. I know, this is also the behaviour of some other filesystems in kpmcore but I should also fix them too. I'll look at the rest of this patch tomorrow.
andrius closed this pull request 2016-05-26 16:20:51 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: andrius/kpmcore#4
No description provided.
Delete Branch "lvm-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?