Commit Graph

1216 Commits

Author SHA1 Message Date
Andrius Štikonas 1344021e1b Move KAuth helper setup code to ExternalCommand class. 2018-04-14 23:56:10 +03:00
Andrius Štikonas 200bb23b67 Disable ok button when it is not visible.
Otherwise it was possible to close the window before all cleanup is done
and later crash the program.
2018-04-13 16:05:13 +03:00
Andrius Štikonas c0385aca3c CoreBackendManager -> CoreBackendManager::self(). 2018-04-13 14:25:11 +03:00
Andrius Štikonas e9ac1cf977 Adjust to kpmcore enum changes. 2018-04-09 15:14:48 +01:00
Andrius Štikonas 96693a8455 Switch Device::Type enum to enum class. 2018-04-09 02:58:03 +01:00
Andrius Štikonas 2137fa58b8 Explicitely specify the scope of FileSystem::Type enum. 2018-04-07 19:54:55 +01:00
Andrius Štikonas 3c9d85d842 Use enums instead of ints when choosing filesystem color in KConfig. 2018-04-07 19:05:05 +01:00
Andrius Štikonas f42da524fc enum -> enum class. 2018-04-05 22:00:06 +01:00
Andrius Štikonas 3eae84de13 Adapt to kpmcore API changes std::array->std::vector. 2018-04-05 21:54:55 +01:00
Huzaifa Faruqui bf65a186bd Removed config option to apply operations as non-root 2018-04-04 00:31:14 +05:30
l10n daemon script 8c8e8f8b47 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-04-03 05:28:21 +02:00
l10n daemon script 8b355027e5 GIT_SILENT made messages (after extraction) 2018-04-03 03:29:14 +02:00
Andrius Štikonas 3aed3ccd93 Remove obsolete CHS information. 2018-04-02 14:01:43 +01:00
Andrius Štikonas 73fef8d69c Revert "Unnecessary use of a pointer for MainWindow."
This reverts commit f33695eb2f.
2018-04-02 13:01:56 +01:00
Andrius Štikonas f33695eb2f Unnecessary use of a pointer for MainWindow. 2018-04-02 01:25:21 +01:00
Andrius Štikonas 6f8cde5520 Use for loop with iterators when removing mount points. 2018-04-01 18:47:45 +01:00
Andrius Štikonas b38db099e0 Merge branch 'master' into kauth 2018-03-31 20:29:15 +01:00
Abhijeet Sharma e54510b881 Multiple mount point support in EditMountPointDialog
Multiple mount points can also be modified and removed from fstab.

Differential Revision: https://phabricator.kde.org/D11632
2018-03-31 20:27:05 +01:00
Andrius Štikonas 2bbf89af28 Fix mutex logic for cancelling operations. 2018-03-31 20:17:38 +01:00
Andrius Štikonas c40a729ba7 Do not allow the second instance of Partition Manager.
BUG: 365882
2018-03-24 22:26:45 +00:00
Caio Carvalho 079e423abd - Including tooltip for SMART attribute description. 2018-03-24 16:16:50 -03:00
Andrius Štikonas d37c0ef9ce Revert "Disallow executing KDE Partition Manager as root."
This reverts commit cfa53f6d3c.
2018-03-22 20:13:58 +00:00
Andrius Štikonas cfa53f6d3c Disallow executing KDE Partition Manager as root.
Summary:
Running GUI applications as root is a huge security risk. Especially
the X server is not secured for that. Non-root applications can easily
interact with a root running application and thus try to exploit simple
bugs in either kate/kwrite itself or in the underlying libraries such
as Qt, XLib or xcb.

On Wayland the situation can be considered worse as the compositor is
running as the normal user and is not protected to handle root windows.
It can be rather trivial to attack the root running application from the
compositor through interfaces such as scripting. This is not in the aim
of the compositors to protect against.

This change introduces a check whether the application is started as
root before any interaction with X or Wayland happens, that is prior to
creating the QApplication. If it is detected that we run as root, we
exit and print an information about how to properly edit an application
in kwrite/kate as root. The text is deliberatly not translated to keep
the threat from running as root as low as possible.

See also Differential Revision: https://phabricator.kde.org/D4634
2018-03-22 17:39:04 +00:00
abhijeet sharma a38a6cd35d Fixed the "remove existing mount point" bug
Summary:
The QString "contains method" is also searching for empty QStrings.
Due to this all entries in /etc/fstab were removed . After this patch it is
searching for only non-empty strings in removeMountPoint() function.

Reviewers: stikonas

Reviewed By: stikonas

Tags: #kde_partition_manager

Differential Revision: https://phabricator.kde.org/D11542
2018-03-22 01:29:13 +05:30
Andrius Štikonas cc73b6c9ce Move external command helper stopping code to kpmcore. 2018-03-21 20:51:10 +01:00
Andrius Štikonas 62a3b57c2d Remove --dontsu command line option. 2018-03-19 16:24:49 +01:00
Andrius Štikonas a1a535cb03 Remove checkPermissions code. 2018-03-19 02:45:18 +01:00
Andrius Štikonas 60e86c3ad6 Stop ExternalCommandHelper before quiting the application. 2018-03-19 02:34:30 +01:00
Andrius Štikonas 98209f90bc No need to explicitely set enum values. 2018-03-03 16:39:52 +00:00
Abhijeet Sharma be07085500 Add possibility to remove an existing mount point
User is able to remove an existing Mount point via
Partition -> Edit Mount Point -> Remove.

Differential Revision: https://phabricator.kde.org/D10514
2018-03-03 16:37:58 +00:00
l10n daemon script 7dd9e17a8c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-03-03 05:26:20 +01:00
l10n daemon script f227a81ff4 GIT_SILENT made messages (after extraction) 2018-03-03 03:19:01 +01:00
Abhijeet Sharma 141f37ed27 Add Partition UUID and Partition Label in partition properties dialog
After this patch partition UUID and partition label will be visible
in the properties dialog of the partitions.

Also these label will only be visible if the partition table is GPT

Differential Revision: https://phabricator.kde.org/D10323
2018-02-13 21:27:05 +00:00
Andrius Štikonas eab21df647 Do not confirm overwrite twice. 2018-02-05 13:14:36 +00:00
Andrius Štikonas fa65cd116b Use defaultBackend from kpmcore.
Do not duplicate the same thing in partitionmanager.kcfg
2018-01-31 18:50:33 +00:00
Abhijeet Sharma 4f2381d7e6 Change default size of device and partition properties dialogs
so as to accommodate all the labels

Differential Revision: https://phabricator.kde.org/D10179
2018-01-30 15:46:05 +00:00
Andrius Štikonas d5bccabac5 Add support for displaying partition labels/uuid.
Differential Revision: https://phabricator.kde.org/D10150
2018-01-27 23:02:36 +00:00
Andrius Štikonas 21755cb449 Remove unused KService dependency. 2018-01-16 17:14:53 +01:00
Andrius Štikonas 74d609a782 Always show Advanced config page. 2018-01-16 15:14:47 +01:00
l10n daemon script e7354c02d1 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-01-13 04:48:00 +01:00
Andrius Štikonas 6252fb480f Merge branch '3.3' 2018-01-07 16:51:50 +02:00
l10n daemon script 523e07cbf5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-01-07 04:56:25 +01:00
Andrius Štikonas 9439e9b1fd Fix a crash when resizing LVM LV. 2018-01-06 23:24:16 +02:00
Andrius Štikonas eaff75dc1b Exclude FileSystem::Luks2 from New File System dialog.
Just like with Luks1, we only want to create Luks2 containers with
some other file system inside.
2017-12-31 08:41:17 +00:00
Andrius Štikonas b4b5dcd804 Add a passphrase request dialog for LUKS2 resizing. 2017-12-31 08:41:17 +00:00
Andrius Štikonas 70f75a3f92 Treat LUKS2 file system as encrypted too. 2017-12-31 08:41:17 +00:00
l10n daemon script 4e1afc8be6 GIT_SILENT made messages (after extraction) 2017-12-25 03:06:33 +01:00
Andrius Štikonas 4b97201539 Add LUKS2 and FAT12 to file system color configuration dialog. 2017-12-24 20:43:26 +00:00
l10n daemon script 7c1ff3cc19 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-12-24 04:48:55 +01:00
l10n daemon script c3b143903c GIT_SILENT made messages (after extraction) 2017-12-20 04:59:43 +01:00
l10n daemon script 26db2cfd8c SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-12-11 04:38:36 +01:00
Andrius Štikonas f322f05037 appdata: use more generic doc URL. 2017-12-05 20:45:32 +00:00
Andrius Štikonas ded99a1497 appdata: update homepage URL, use https for links 2017-12-05 20:11:25 +00:00
Andrius Štikonas d25523e43a Properly save new fstab entries. 2017-12-03 00:17:19 +00:00
Andrius Štikonas d4c72ad075 Fix creation of FAT mountpoints.
BUG: 387463
2017-11-30 23:33:35 +00:00
l10n daemon script a6ed618ba6 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-11-27 04:58:05 +01:00
l10n daemon script 7e29cf6c62 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-11-20 04:32:00 +01:00
Andrius Štikonas ecec8dadda Do not display cylinder/head/sector information.
CHS has never been important for Linux.
2017-11-07 00:51:59 +00:00
Andrius Štikonas f639d965dd Fix saving new backend when clicking Ok button.
When clicking Ok, dialog gets hidden and we never set the new backend.
2017-11-07 00:47:04 +00:00
Andrius Štikonas f62edf052c Move LVM LV setup code to the base class.
The same checks (e.g. hide LVM LV name edit line) are also needed
in the other children of SizeDialogBase.
2017-10-28 19:02:26 +01:00
l10n daemon script 0b1780397e SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-10-24 05:07:07 +02:00
Andrius Štikonas b7fdd6e4c4 Don't repeat work of KAboutData::setupCommandLine(). 2017-10-11 00:20:03 +01:00
Andrius Štikonas f105f448b3 Add a validator for LVM LV names. 2017-10-09 23:56:15 +01:00
Andrius Štikonas f30a3c999f Add what's it entry to Recreate Existing File System checkbox.
BUG: 385524
2017-10-09 18:42:39 +01:00
Andrius Štikonas ca42730d39 Fix a typo in a comment. 2017-10-09 17:08:27 +01:00
Andrius Štikonas e512ed337a Use qOverload in Qt signal/slots. 2017-10-09 13:54:31 +01:00
Andrius Štikonas d38b889a22 Merge branch '3.2' 2017-10-06 18:54:25 -04:00
Andrius Štikonas f34733e824 Fix regexp++. 2017-10-06 23:48:52 +01:00
Andrius Štikonas eb6478aa49 Fix a broken QRegularExpression in LVM VG name validator. 2017-10-06 23:16:30 +01:00
l10n daemon script 8baad25d47 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-10-02 05:00:54 +02:00
Andrius Štikonas 7ca06a74ae Update credits. 2017-10-02 01:40:14 +01:00
Andrius Štikonas cd9c4ab36b Port away from KService. 2017-10-01 22:07:21 +01:00
l10n daemon script 38d9c72466 GIT_SILENT made messages (after extraction) 2017-10-01 03:28:58 +02:00
l10n daemon script c9e9d31236 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-30 05:08:31 +02:00
l10n daemon script 485632e6e5 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-26 04:54:03 +02:00
l10n daemon script 9872a44597 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-23 04:55:31 +02:00
l10n daemon script a8189399af SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-22 04:55:58 +02:00
Andrius Štikonas cf14bdcac8 Use canonical device paths when comparing them. 2017-09-20 21:22:32 +01:00
Andrius Štikonas 9407c1ede4 Fix KUIT markup. 2017-09-20 20:39:59 +01:00
Andrius Štikonas 1c176ad5f4 Workaround for different swap naming conventions. 2017-09-18 15:21:47 +01:00
Andrius Štikonas 454845e14e Port from MountEntry to FstabEntry.
This helps to preserve comments in fstab file

BUG: 305469
2017-09-16 20:41:45 +01:00
Andrius Štikonas 24237a6120 Change a way untranslated file system name is accessed. 2017-09-15 12:47:28 +01:00
Andrius Štikonas f29656ca45 Move showColumnsContextMenu function from kpmcore to partitionmanager. 2017-09-14 20:42:43 +01:00
Andrius Štikonas 4b4198c34a Use untranslated file system name when importing partition table.
BUG: 364648
2017-09-14 14:47:39 +01:00
Jonathan Riddell f8f74d1698 revert duplicate commit 2017-09-13 15:30:00 +01:00
Jonathan Riddell a4d7832f86 Add freedesktop.org keywords to .desktop file, Author: Jonathan Carter <jcarter@linux.com> 2017-09-13 15:17:41 +01:00
l10n daemon script 931b1e90e0 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-13 08:45:37 +02:00
l10n daemon script 385507c3cb SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-12 04:49:41 +02:00
Andrius Štikonas aa762266ae Fix some minor clang warnings. 2017-09-11 18:46:48 +01:00
Andrius Štikonas 78eca538d6 Remove double underscore from include guards. 2017-09-11 16:28:04 +01:00
l10n daemon script 688b21f9f7 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-11 04:50:44 +02:00
Andrius Štikonas 9348e14b01 Update credits: Pali Rohár 2017-09-10 18:04:04 +01:00
l10n daemon script d70c1ab373 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-10 04:50:43 +02:00
Andrius Štikonas 112b6c9f07 Move IconThemes dependency from kpmcore to partitionmanager. 2017-09-08 15:06:08 +01:00
Andrius Štikonas d076291973 Add support for detecting ISO9660 file systems. 2017-09-08 11:43:31 +01:00
l10n daemon script 1dd8e32d40 SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2017-09-08 04:30:49 +02:00
Andrius Štikonas eb80d94586 Merge branch 'next2' 2017-09-08 01:05:50 +01:00
Andrius Štikonas 421515dcaa Add partition;disk keywords to the desktop file. 2017-09-06 14:12:15 +01:00
Andrius Štikonas a9047ca6e2 Merge branch 'master' into next2 2017-09-06 00:10:29 +01:00
Andrius Štikonas feb2e374e4 Fix a crash when clicking cancel in ApplyProgressDialog.
BUG: 384348
2017-09-06 00:07:11 +01:00