andrius
/
partitionmanager
1
0
Fork 0
Code Pull Requests Releases Activity

Add PV's info to the infopane #1

Closed
Ghost wants to merge 1 commits from (deleted):lvm-support into master
pull from: (deleted):lvm-support
merge into: andrius:master
Conversation 1 Commits 1 Files Changed 1 +16
Ghost commented 2016-05-25 21:12:10 +01:00
First-time contributor
Copy Link

This requires the update of fs::lvm2_pv class in the kpmcore's lvm-support branch.

This requires the update of fs::lvm2_pv class in the kpmcore's lvm-support branch.
andrius commented 2016-05-26 00:32:23 +01:00
Owner
Copy Link

This looks fine. Feel free to commit it once kpmcore patch is reviewed and committed.

I wonder if it's possible to do this in less special case basis, so that more code is in kpmcore/fs and not here in gui. Volker's TODO file in partitionmanager also has this task:

  • Information about file system on a separate tab in the properties, unique to the file system in use.

But I guess for the moment we have to leave it like that.

This looks fine. Feel free to commit it once kpmcore patch is reviewed and committed. I wonder if it's possible to do this in less special case basis, so that more code is in kpmcore/fs and not here in gui. Volker's TODO file in partitionmanager also has this task: * Information about file system on a separate tab in the properties, unique to the file system in use. But I guess for the moment we have to leave it like that.
Ghost closed this pull request 2016-05-26 21:33:56 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: andrius/partitionmanager#1
No description provided.
Delete Branch "(deleted):lvm-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?